* [patch net-2.6] bonding: fix rx_handler locking
@ 2011-03-22 12:38 Jiri Pirko
2011-03-22 20:26 ` Andy Gospodarek
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jiri Pirko @ 2011-03-22 12:38 UTC (permalink / raw)
To: netdev; +Cc: davem, nicolas.2p.debian, andy, fubar
This prevents possible race between bond_enslave and bond_handle_frame
as reported by Nicolas by moving rx_handler register/unregister.
slave->bond is added to hold pointer to master bonding sructure. That
way dev->master is no longer used in bond_handler_frame.
Also, this removes "BUG: scheduling while atomic" message
Reported-by: Nicolas de Pesloüan <nicolas.2p.debian@gmail.com>
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
---
drivers/net/bonding/bond_main.c | 56 +++++++++++++++++++++-----------------
drivers/net/bonding/bonding.h | 1 +
2 files changed, 32 insertions(+), 25 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 338bea1..16d6fe9 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1482,21 +1482,16 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
{
struct sk_buff *skb = *pskb;
struct slave *slave;
- struct net_device *bond_dev;
struct bonding *bond;
- slave = bond_slave_get_rcu(skb->dev);
- bond_dev = ACCESS_ONCE(slave->dev->master);
- if (unlikely(!bond_dev))
- return RX_HANDLER_PASS;
-
skb = skb_share_check(skb, GFP_ATOMIC);
if (unlikely(!skb))
return RX_HANDLER_CONSUMED;
*pskb = skb;
- bond = netdev_priv(bond_dev);
+ slave = bond_slave_get_rcu(skb->dev);
+ bond = slave->bond;
if (bond->params.arp_interval)
slave->dev->last_rx = jiffies;
@@ -1505,10 +1500,10 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
return RX_HANDLER_EXACT;
}
- skb->dev = bond_dev;
+ skb->dev = bond->dev;
if (bond->params.mode == BOND_MODE_ALB &&
- bond_dev->priv_flags & IFF_BRIDGE_PORT &&
+ bond->dev->priv_flags & IFF_BRIDGE_PORT &&
skb->pkt_type == PACKET_HOST) {
if (unlikely(skb_cow_head(skb,
@@ -1516,7 +1511,7 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
kfree_skb(skb);
return RX_HANDLER_CONSUMED;
}
- memcpy(eth_hdr(skb)->h_dest, bond_dev->dev_addr, ETH_ALEN);
+ memcpy(eth_hdr(skb)->h_dest, bond->dev->dev_addr, ETH_ALEN);
}
return RX_HANDLER_ANOTHER;
@@ -1698,20 +1693,15 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
pr_debug("Error %d calling netdev_set_bond_master\n", res);
goto err_restore_mac;
}
- res = netdev_rx_handler_register(slave_dev, bond_handle_frame,
- new_slave);
- if (res) {
- pr_debug("Error %d calling netdev_rx_handler_register\n", res);
- goto err_unset_master;
- }
/* open the slave since the application closed it */
res = dev_open(slave_dev);
if (res) {
pr_debug("Opening slave %s failed\n", slave_dev->name);
- goto err_unreg_rxhandler;
+ goto err_unset_master;
}
+ new_slave->bond = bond;
new_slave->dev = slave_dev;
slave_dev->priv_flags |= IFF_BONDING;
@@ -1907,6 +1897,13 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
if (res)
goto err_close;
+ res = netdev_rx_handler_register(slave_dev, bond_handle_frame,
+ new_slave);
+ if (res) {
+ pr_debug("Error %d calling netdev_rx_handler_register\n", res);
+ goto err_dest_symlinks;
+ }
+
pr_info("%s: enslaving %s as a%s interface with a%s link.\n",
bond_dev->name, slave_dev->name,
bond_is_active_slave(new_slave) ? "n active" : " backup",
@@ -1916,13 +1913,12 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
return 0;
/* Undo stages on error */
+err_dest_symlinks:
+ bond_destroy_slave_symlinks(bond_dev, slave_dev);
+
err_close:
dev_close(slave_dev);
-err_unreg_rxhandler:
- netdev_rx_handler_unregister(slave_dev);
- synchronize_net();
-
err_unset_master:
netdev_set_bond_master(slave_dev, NULL);
@@ -1988,6 +1984,14 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
return -EINVAL;
}
+ /* unregister rx_handler early so bond_handle_frame wouldn't be called
+ * for this slave anymore.
+ */
+ netdev_rx_handler_unregister(slave_dev);
+ write_unlock_bh(&bond->lock);
+ synchronize_net();
+ write_lock_bh(&bond->lock);
+
if (!bond->params.fail_over_mac) {
if (!compare_ether_addr(bond_dev->dev_addr, slave->perm_hwaddr) &&
bond->slave_cnt > 1)
@@ -2104,8 +2108,6 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
netif_addr_unlock_bh(bond_dev);
}
- netdev_rx_handler_unregister(slave_dev);
- synchronize_net();
netdev_set_bond_master(slave_dev, NULL);
slave_disable_netpoll(slave);
@@ -2186,6 +2188,12 @@ static int bond_release_all(struct net_device *bond_dev)
*/
write_unlock_bh(&bond->lock);
+ /* unregister rx_handler early so bond_handle_frame wouldn't
+ * be called for this slave anymore.
+ */
+ netdev_rx_handler_unregister(slave_dev);
+ synchronize_net();
+
if (bond_is_lb(bond)) {
/* must be called only after the slave
* has been detached from the list
@@ -2217,8 +2225,6 @@ static int bond_release_all(struct net_device *bond_dev)
netif_addr_unlock_bh(bond_dev);
}
- netdev_rx_handler_unregister(slave_dev);
- synchronize_net();
netdev_set_bond_master(slave_dev, NULL);
slave_disable_netpoll(slave);
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 6b26962..90736cb 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -187,6 +187,7 @@ struct slave {
struct net_device *dev; /* first - useful for panic debug */
struct slave *next;
struct slave *prev;
+ struct bonding *bond; /* our master */
int delay;
unsigned long jiffies;
unsigned long last_arp_rx;
--
1.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch net-2.6] bonding: fix rx_handler locking
2011-03-22 12:38 [patch net-2.6] bonding: fix rx_handler locking Jiri Pirko
@ 2011-03-22 20:26 ` Andy Gospodarek
2011-03-22 20:35 ` Nicolas de Pesloüan
2011-03-23 2:07 ` Weiping Pan
2011-03-23 19:25 ` Nicolas de Pesloüan
2 siblings, 1 reply; 8+ messages in thread
From: Andy Gospodarek @ 2011-03-22 20:26 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, nicolas.2p.debian, andy, fubar
On Tue, Mar 22, 2011 at 01:38:12PM +0100, Jiri Pirko wrote:
> This prevents possible race between bond_enslave and bond_handle_frame
> as reported by Nicolas by moving rx_handler register/unregister.
> slave->bond is added to hold pointer to master bonding sructure. That
> way dev->master is no longer used in bond_handler_frame.
> Also, this removes "BUG: scheduling while atomic" message
>
> Reported-by: Nicolas de Pesloüan <nicolas.2p.debian@gmail.com>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
This seems reasonable. I presume Nicolas was able to test it and verify
it resolved his issue?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch net-2.6] bonding: fix rx_handler locking
2011-03-22 20:26 ` Andy Gospodarek
@ 2011-03-22 20:35 ` Nicolas de Pesloüan
0 siblings, 0 replies; 8+ messages in thread
From: Nicolas de Pesloüan @ 2011-03-22 20:35 UTC (permalink / raw)
To: Andy Gospodarek; +Cc: Jiri Pirko, netdev, davem, fubar
Le 22/03/2011 21:26, Andy Gospodarek a écrit :
> On Tue, Mar 22, 2011 at 01:38:12PM +0100, Jiri Pirko wrote:
>> This prevents possible race between bond_enslave and bond_handle_frame
>> as reported by Nicolas by moving rx_handler register/unregister.
>> slave->bond is added to hold pointer to master bonding sructure. That
>> way dev->master is no longer used in bond_handler_frame.
>> Also, this removes "BUG: scheduling while atomic" message
>>
>> Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>
>> Signed-off-by: Jiri Pirko<jpirko@redhat.com>
>
> Signed-off-by: Andy Gospodarek<andy@greyhouse.net>
>
> This seems reasonable. I presume Nicolas was able to test it and verify
> it resolved his issue?
Unfortunately, not yet. I plan to give it a try tonight... or tomorrow on the worst case.
Nicolas.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch net-2.6] bonding: fix rx_handler locking
2011-03-22 12:38 [patch net-2.6] bonding: fix rx_handler locking Jiri Pirko
2011-03-22 20:26 ` Andy Gospodarek
@ 2011-03-23 2:07 ` Weiping Pan
2011-03-23 2:16 ` David Miller
2011-03-23 19:25 ` Nicolas de Pesloüan
2 siblings, 1 reply; 8+ messages in thread
From: Weiping Pan @ 2011-03-23 2:07 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, nicolas.2p.debian, andy, fubar
On 03/22/2011 08:38 PM, Jiri Pirko wrote:
> This prevents possible race between bond_enslave and bond_handle_frame
> as reported by Nicolas by moving rx_handler register/unregister.
> slave->bond is added to hold pointer to master bonding sructure. That
> way dev->master is no longer used in bond_handler_frame.
> Also, this removes "BUG: scheduling while atomic" message
>
> Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>
> Signed-off-by: Jiri Pirko<jpirko@redhat.com>
> ---
> drivers/net/bonding/bond_main.c | 56 +++++++++++++++++++++-----------------
> drivers/net/bonding/bonding.h | 1 +
> 2 files changed, 32 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 338bea1..16d6fe9 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1482,21 +1482,16 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
> {
> struct sk_buff *skb = *pskb;
> struct slave *slave;
> - struct net_device *bond_dev;
> struct bonding *bond;
>
> - slave = bond_slave_get_rcu(skb->dev);
> - bond_dev = ACCESS_ONCE(slave->dev->master);
> - if (unlikely(!bond_dev))
> - return RX_HANDLER_PASS;
> -
> skb = skb_share_check(skb, GFP_ATOMIC);
> if (unlikely(!skb))
> return RX_HANDLER_CONSUMED;
>
> *pskb = skb;
>
> - bond = netdev_priv(bond_dev);
> + slave = bond_slave_get_rcu(skb->dev);
> + bond = slave->bond;
>
> if (bond->params.arp_interval)
> slave->dev->last_rx = jiffies;
> @@ -1505,10 +1500,10 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
> return RX_HANDLER_EXACT;
> }
>
> - skb->dev = bond_dev;
> + skb->dev = bond->dev;
>
> if (bond->params.mode == BOND_MODE_ALB&&
> - bond_dev->priv_flags& IFF_BRIDGE_PORT&&
> + bond->dev->priv_flags& IFF_BRIDGE_PORT&&
> skb->pkt_type == PACKET_HOST) {
>
> if (unlikely(skb_cow_head(skb,
> @@ -1516,7 +1511,7 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
> kfree_skb(skb);
> return RX_HANDLER_CONSUMED;
> }
> - memcpy(eth_hdr(skb)->h_dest, bond_dev->dev_addr, ETH_ALEN);
> + memcpy(eth_hdr(skb)->h_dest, bond->dev->dev_addr, ETH_ALEN);
> }
>
> return RX_HANDLER_ANOTHER;
> @@ -1698,20 +1693,15 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
> pr_debug("Error %d calling netdev_set_bond_master\n", res);
> goto err_restore_mac;
> }
> - res = netdev_rx_handler_register(slave_dev, bond_handle_frame,
> - new_slave);
> - if (res) {
> - pr_debug("Error %d calling netdev_rx_handler_register\n", res);
> - goto err_unset_master;
> - }
>
> /* open the slave since the application closed it */
> res = dev_open(slave_dev);
> if (res) {
> pr_debug("Opening slave %s failed\n", slave_dev->name);
> - goto err_unreg_rxhandler;
> + goto err_unset_master;
> }
>
> + new_slave->bond = bond;
> new_slave->dev = slave_dev;
> slave_dev->priv_flags |= IFF_BONDING;
>
> @@ -1907,6 +1897,13 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
> if (res)
> goto err_close;
>
> + res = netdev_rx_handler_register(slave_dev, bond_handle_frame,
> + new_slave);
> + if (res) {
> + pr_debug("Error %d calling netdev_rx_handler_register\n", res);
> + goto err_dest_symlinks;
> + }
> +
> pr_info("%s: enslaving %s as a%s interface with a%s link.\n",
> bond_dev->name, slave_dev->name,
> bond_is_active_slave(new_slave) ? "n active" : " backup",
> @@ -1916,13 +1913,12 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
> return 0;
>
> /* Undo stages on error */
> +err_dest_symlinks:
> + bond_destroy_slave_symlinks(bond_dev, slave_dev);
> +
> err_close:
> dev_close(slave_dev);
>
> -err_unreg_rxhandler:
> - netdev_rx_handler_unregister(slave_dev);
> - synchronize_net();
> -
> err_unset_master:
> netdev_set_bond_master(slave_dev, NULL);
>
> @@ -1988,6 +1984,14 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
> return -EINVAL;
> }
>
> + /* unregister rx_handler early so bond_handle_frame wouldn't be called
> + * for this slave anymore.
> + */
> + netdev_rx_handler_unregister(slave_dev);
> + write_unlock_bh(&bond->lock);
> + synchronize_net();
> + write_lock_bh(&bond->lock);
> +
> if (!bond->params.fail_over_mac) {
> if (!compare_ether_addr(bond_dev->dev_addr, slave->perm_hwaddr)&&
> bond->slave_cnt> 1)
> @@ -2104,8 +2108,6 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev)
> netif_addr_unlock_bh(bond_dev);
> }
>
> - netdev_rx_handler_unregister(slave_dev);
> - synchronize_net();
> netdev_set_bond_master(slave_dev, NULL);
>
> slave_disable_netpoll(slave);
> @@ -2186,6 +2188,12 @@ static int bond_release_all(struct net_device *bond_dev)
> */
> write_unlock_bh(&bond->lock);
>
> + /* unregister rx_handler early so bond_handle_frame wouldn't
> + * be called for this slave anymore.
> + */
> + netdev_rx_handler_unregister(slave_dev);
> + synchronize_net();
> +
> if (bond_is_lb(bond)) {
> /* must be called only after the slave
> * has been detached from the list
> @@ -2217,8 +2225,6 @@ static int bond_release_all(struct net_device *bond_dev)
> netif_addr_unlock_bh(bond_dev);
> }
>
> - netdev_rx_handler_unregister(slave_dev);
> - synchronize_net();
> netdev_set_bond_master(slave_dev, NULL);
>
> slave_disable_netpoll(slave);
> diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
> index 6b26962..90736cb 100644
> --- a/drivers/net/bonding/bonding.h
> +++ b/drivers/net/bonding/bonding.h
> @@ -187,6 +187,7 @@ struct slave {
> struct net_device *dev; /* first - useful for panic debug */
> struct slave *next;
> struct slave *prev;
> + struct bonding *bond; /* our master */
> int delay;
> unsigned long jiffies;
> unsigned long last_arp_rx;
Hi,
I test this patch with VirtualBox, no kernel panic occurs.
git log 08351fc6a75731226e1112fc7254542bd3a2912e
[root@localhost ~]# vboxmanage showvminfo server |grep ^NIC
NIC 1: MAC: 0800273A4DBD, Attachment: Bridged Interface
'eth0', Cable connected: on, Trace: off (file: none), Type: 82540EM,
Reported speed: 0 Mbps, Boot priority: 0
NIC 2: MAC: 080027B5FCD1, Attachment: Bridged Interface
'eth0', Cable connected: on, Trace: off (file: none), Type: 82540EM,
Reported speed: 0 Mbps, Boot priority: 0
NIC 3: MAC: 080027C77BFC, Attachment: Bridged Interface
'eth0', Cable connected: on, Trace: off (file: none), Type: 82540EM,
Reported speed: 0 Mbps, Boot priority: 0
NIC 4: MAC: 080027261BDB, Attachment: Bridged Interface
'eth0', Cable connected: on, Trace: off (file: none), Type: 82540EM,
Reported speed: 0 Mbps, Boot priority: 0
NIC 5: disabled
NIC 6: disabled
NIC 7: disabled
NIC 8: disabled
Here is my test case.
#! /bin/sh
ifconfig eth9 down
NUM=0
for i in {1..100}
do
modprobe -r bonding
modprobe bonding max_bonds=0
echo +bond0 > /sys/class/net/bonding_masters
echo +bond1 > /sys/class/net/bonding_masters
echo +eth9 > /sys/class/net/bond1/bonding/slaves
echo $i " PASS"
(( NUM += 1))
done
echo $NUM " PASS"
Hope it will be useful for you.
thanks
Weiping Pan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch net-2.6] bonding: fix rx_handler locking
2011-03-23 2:07 ` Weiping Pan
@ 2011-03-23 2:16 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2011-03-23 2:16 UTC (permalink / raw)
To: panweiping3; +Cc: jpirko, netdev, nicolas.2p.debian, andy, fubar
From: Weiping Pan <panweiping3@gmail.com>
Date: Wed, 23 Mar 2011 10:07:10 +0800
> On 03/22/2011 08:38 PM, Jiri Pirko wrote:
>> This prevents possible race between bond_enslave and bond_handle_frame
>> as reported by Nicolas by moving rx_handler register/unregister.
>> slave->bond is added to hold pointer to master bonding sructure. That
>> way dev->master is no longer used in bond_handler_frame.
>> Also, this removes "BUG: scheduling while atomic" message
>>
>> Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>
>> Signed-off-by: Jiri Pirko<jpirko@redhat.com>
...
> I test this patch with VirtualBox, no kernel panic occurs.
Thanks a lot Weiping.
Once I have test confirmwation from Nicolas I will apply this patch.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch net-2.6] bonding: fix rx_handler locking
2011-03-22 12:38 [patch net-2.6] bonding: fix rx_handler locking Jiri Pirko
2011-03-22 20:26 ` Andy Gospodarek
2011-03-23 2:07 ` Weiping Pan
@ 2011-03-23 19:25 ` Nicolas de Pesloüan
2011-03-23 19:45 ` David Miller
2011-03-23 21:16 ` Jiri Pirko
2 siblings, 2 replies; 8+ messages in thread
From: Nicolas de Pesloüan @ 2011-03-23 19:25 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, davem, andy, fubar
Le 22/03/2011 13:38, Jiri Pirko a écrit :
> This prevents possible race between bond_enslave and bond_handle_frame
> as reported by Nicolas by moving rx_handler register/unregister.
> slave->bond is added to hold pointer to master bonding sructure. That
> way dev->master is no longer used in bond_handler_frame.
> Also, this removes "BUG: scheduling while atomic" message
>
> Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>
> Signed-off-by: Jiri Pirko<jpirko@redhat.com>
Thanks Jiri, it works.
Tested-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Regarding the code review, can you explain the reasons why you apparently duplicated the fields
related to the slave/master relationship?
Do you plan to totally remove dev->master usage in bonding in a follow-up patch?
Nicolas.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch net-2.6] bonding: fix rx_handler locking
2011-03-23 19:25 ` Nicolas de Pesloüan
@ 2011-03-23 19:45 ` David Miller
2011-03-23 21:16 ` Jiri Pirko
1 sibling, 0 replies; 8+ messages in thread
From: David Miller @ 2011-03-23 19:45 UTC (permalink / raw)
To: nicolas.2p.debian; +Cc: jpirko, netdev, andy, fubar
From: Nicolas de Pesloüan <nicolas.2p.debian@gmail.com>
Date: Wed, 23 Mar 2011 20:25:37 +0100
> Le 22/03/2011 13:38, Jiri Pirko a écrit :
>> This prevents possible race between bond_enslave and bond_handle_frame
>> as reported by Nicolas by moving rx_handler register/unregister.
>> slave->bond is added to hold pointer to master bonding sructure. That
>> way dev->master is no longer used in bond_handler_frame.
>> Also, this removes "BUG: scheduling while atomic" message
>>
>> Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>
>> Signed-off-by: Jiri Pirko<jpirko@redhat.com>
>
> Thanks Jiri, it works.
>
> Tested-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch net-2.6] bonding: fix rx_handler locking
2011-03-23 19:25 ` Nicolas de Pesloüan
2011-03-23 19:45 ` David Miller
@ 2011-03-23 21:16 ` Jiri Pirko
1 sibling, 0 replies; 8+ messages in thread
From: Jiri Pirko @ 2011-03-23 21:16 UTC (permalink / raw)
To: Nicolas de Pesloüan; +Cc: netdev, davem, andy, fubar
Wed, Mar 23, 2011 at 08:25:37PM CET, nicolas.2p.debian@gmail.com wrote:
>Le 22/03/2011 13:38, Jiri Pirko a écrit :
>>This prevents possible race between bond_enslave and bond_handle_frame
>>as reported by Nicolas by moving rx_handler register/unregister.
>>slave->bond is added to hold pointer to master bonding sructure. That
>>way dev->master is no longer used in bond_handler_frame.
>>Also, this removes "BUG: scheduling while atomic" message
>>
>>Reported-by: Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>
>>Signed-off-by: Jiri Pirko<jpirko@redhat.com>
>
>Thanks Jiri, it works.
>
>Tested-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
>
>Regarding the code review, can you explain the reasons why you
>apparently duplicated the fields related to the slave/master
>relationship?
>
>Do you plan to totally remove dev->master usage in bonding in a follow-up patch?
dev->master could be possibly retired. Not sure yet. It's on my todo
list.
>
> Nicolas.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-03-23 21:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-22 12:38 [patch net-2.6] bonding: fix rx_handler locking Jiri Pirko
2011-03-22 20:26 ` Andy Gospodarek
2011-03-22 20:35 ` Nicolas de Pesloüan
2011-03-23 2:07 ` Weiping Pan
2011-03-23 2:16 ` David Miller
2011-03-23 19:25 ` Nicolas de Pesloüan
2011-03-23 19:45 ` David Miller
2011-03-23 21:16 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).