* [PATCH] xfrm: fix error checking in xfrm_output_gso
@ 2011-10-27 5:33 Yan, Zheng
2011-10-28 0:47 ` Yan, Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Yan, Zheng @ 2011-10-27 5:33 UTC (permalink / raw)
To: netdev; +Cc: Herbert Xu, davem
xfrm_output2() returns 1 on success. This bug makes xfrm_output_gso()
drop all segments except the first one.
Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
---
diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
index 47bacd8..04e963a 100644
--- a/net/xfrm/xfrm_output.c
+++ b/net/xfrm/xfrm_output.c
@@ -159,7 +159,7 @@ static int xfrm_output_gso(struct sk_buff *skb)
segs->next = NULL;
err = xfrm_output2(segs);
- if (unlikely(err)) {
+ if (unlikely(err < 0)) {
while ((segs = nskb)) {
nskb = segs->next;
segs->next = NULL;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xfrm: fix error checking in xfrm_output_gso
2011-10-27 5:33 [PATCH] xfrm: fix error checking in xfrm_output_gso Yan, Zheng
@ 2011-10-28 0:47 ` Yan, Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Yan, Zheng @ 2011-10-28 0:47 UTC (permalink / raw)
To: netdev; +Cc: Herbert Xu, davem
On 10/27/2011 01:33 PM, Yan, Zheng wrote:
> xfrm_output2() returns 1 on success. This bug makes xfrm_output_gso()
> drop all segments except the first one.
>
> Signed-off-by: Zheng Yan <zheng.z.yan@intel.com>
> ---
> diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
> index 47bacd8..04e963a 100644
> --- a/net/xfrm/xfrm_output.c
> +++ b/net/xfrm/xfrm_output.c
> @@ -159,7 +159,7 @@ static int xfrm_output_gso(struct sk_buff *skb)
> segs->next = NULL;
> err = xfrm_output2(segs);
>
> - if (unlikely(err)) {
> + if (unlikely(err < 0)) {
> while ((segs = nskb)) {
> nskb = segs->next;
> segs->next = NULL;
Return 1 means collision, please ignore this patch. Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-28 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-27 5:33 [PATCH] xfrm: fix error checking in xfrm_output_gso Yan, Zheng
2011-10-28 0:47 ` Yan, Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).