From: Sibi Sankar <quic_sibis@quicinc.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
Alex Elder <elder@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Kalle Valo <kvalo@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@somainline.org>
Cc: <linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] net: ipa: Make QMI message rules const
Date: Wed, 14 Sep 2022 15:52:12 +0530 [thread overview]
Message-ID: <4fe0283d-d2f4-a593-0748-a180e3589832@quicinc.com> (raw)
In-Reply-To: <20220912232526.27427-2-quic_jjohnson@quicinc.com>
On 9/13/22 4:55 AM, Jeff Johnson wrote:
> Commit ff6d365898d ("soc: qcom: qmi: use const for struct
> qmi_elem_info") allows QMI message encoding/decoding rules to be
> const, so do that for IPA.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
> drivers/net/ipa/ipa_qmi_msg.c | 20 ++++++++++----------
> drivers/net/ipa/ipa_qmi_msg.h | 20 ++++++++++----------
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c
> index 6838e8065072..c5a5dac284a9 100644
> --- a/drivers/net/ipa/ipa_qmi_msg.c
> +++ b/drivers/net/ipa/ipa_qmi_msg.c
> @@ -9,7 +9,7 @@
> #include "ipa_qmi_msg.h"
>
> /* QMI message structure definition for struct ipa_indication_register_req */
> -struct qmi_elem_info ipa_indication_register_req_ei[] = {
> +const struct qmi_elem_info ipa_indication_register_req_ei[] = {
> {
> .data_type = QMI_OPT_FLAG,
> .elem_len = 1,
> @@ -116,7 +116,7 @@ struct qmi_elem_info ipa_indication_register_req_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_indication_register_rsp */
> -struct qmi_elem_info ipa_indication_register_rsp_ei[] = {
> +const struct qmi_elem_info ipa_indication_register_rsp_ei[] = {
> {
> .data_type = QMI_STRUCT,
> .elem_len = 1,
> @@ -134,7 +134,7 @@ struct qmi_elem_info ipa_indication_register_rsp_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_driver_init_complete_req */
> -struct qmi_elem_info ipa_driver_init_complete_req_ei[] = {
> +const struct qmi_elem_info ipa_driver_init_complete_req_ei[] = {
> {
> .data_type = QMI_UNSIGNED_1_BYTE,
> .elem_len = 1,
> @@ -151,7 +151,7 @@ struct qmi_elem_info ipa_driver_init_complete_req_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_driver_init_complete_rsp */
> -struct qmi_elem_info ipa_driver_init_complete_rsp_ei[] = {
> +const struct qmi_elem_info ipa_driver_init_complete_rsp_ei[] = {
> {
> .data_type = QMI_STRUCT,
> .elem_len = 1,
> @@ -169,7 +169,7 @@ struct qmi_elem_info ipa_driver_init_complete_rsp_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_init_complete_ind */
> -struct qmi_elem_info ipa_init_complete_ind_ei[] = {
> +const struct qmi_elem_info ipa_init_complete_ind_ei[] = {
> {
> .data_type = QMI_STRUCT,
> .elem_len = 1,
> @@ -187,7 +187,7 @@ struct qmi_elem_info ipa_init_complete_ind_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_mem_bounds */
> -struct qmi_elem_info ipa_mem_bounds_ei[] = {
> +const struct qmi_elem_info ipa_mem_bounds_ei[] = {
> {
> .data_type = QMI_UNSIGNED_4_BYTE,
> .elem_len = 1,
> @@ -208,7 +208,7 @@ struct qmi_elem_info ipa_mem_bounds_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_mem_array */
> -struct qmi_elem_info ipa_mem_array_ei[] = {
> +const struct qmi_elem_info ipa_mem_array_ei[] = {
> {
> .data_type = QMI_UNSIGNED_4_BYTE,
> .elem_len = 1,
> @@ -229,7 +229,7 @@ struct qmi_elem_info ipa_mem_array_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_mem_range */
> -struct qmi_elem_info ipa_mem_range_ei[] = {
> +const struct qmi_elem_info ipa_mem_range_ei[] = {
> {
> .data_type = QMI_UNSIGNED_4_BYTE,
> .elem_len = 1,
> @@ -250,7 +250,7 @@ struct qmi_elem_info ipa_mem_range_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_init_modem_driver_req */
> -struct qmi_elem_info ipa_init_modem_driver_req_ei[] = {
> +const struct qmi_elem_info ipa_init_modem_driver_req_ei[] = {
> {
> .data_type = QMI_OPT_FLAG,
> .elem_len = 1,
> @@ -645,7 +645,7 @@ struct qmi_elem_info ipa_init_modem_driver_req_ei[] = {
> };
>
> /* QMI message structure definition for struct ipa_init_modem_driver_rsp */
> -struct qmi_elem_info ipa_init_modem_driver_rsp_ei[] = {
> +const struct qmi_elem_info ipa_init_modem_driver_rsp_ei[] = {
> {
> .data_type = QMI_STRUCT,
> .elem_len = 1,
> diff --git a/drivers/net/ipa/ipa_qmi_msg.h b/drivers/net/ipa/ipa_qmi_msg.h
> index 495e85abe50b..8dfac59ea0ed 100644
> --- a/drivers/net/ipa/ipa_qmi_msg.h
> +++ b/drivers/net/ipa/ipa_qmi_msg.h
> @@ -242,15 +242,15 @@ struct ipa_init_modem_driver_rsp {
> };
>
> /* Message structure definitions defined in "ipa_qmi_msg.c" */
> -extern struct qmi_elem_info ipa_indication_register_req_ei[];
> -extern struct qmi_elem_info ipa_indication_register_rsp_ei[];
> -extern struct qmi_elem_info ipa_driver_init_complete_req_ei[];
> -extern struct qmi_elem_info ipa_driver_init_complete_rsp_ei[];
> -extern struct qmi_elem_info ipa_init_complete_ind_ei[];
> -extern struct qmi_elem_info ipa_mem_bounds_ei[];
> -extern struct qmi_elem_info ipa_mem_array_ei[];
> -extern struct qmi_elem_info ipa_mem_range_ei[];
> -extern struct qmi_elem_info ipa_init_modem_driver_req_ei[];
> -extern struct qmi_elem_info ipa_init_modem_driver_rsp_ei[];
> +extern const struct qmi_elem_info ipa_indication_register_req_ei[];
> +extern const struct qmi_elem_info ipa_indication_register_rsp_ei[];
> +extern const struct qmi_elem_info ipa_driver_init_complete_req_ei[];
> +extern const struct qmi_elem_info ipa_driver_init_complete_rsp_ei[];
> +extern const struct qmi_elem_info ipa_init_complete_ind_ei[];
> +extern const struct qmi_elem_info ipa_mem_bounds_ei[];
> +extern const struct qmi_elem_info ipa_mem_array_ei[];
> +extern const struct qmi_elem_info ipa_mem_range_ei[];
> +extern const struct qmi_elem_info ipa_init_modem_driver_req_ei[];
> +extern const struct qmi_elem_info ipa_init_modem_driver_rsp_ei[];
>
> #endif /* !_IPA_QMI_MSG_H_ */
>
next prev parent reply other threads:[~2022-09-14 10:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 23:25 [PATCH 0/4] Make QMI message rules const Jeff Johnson
2022-09-12 23:25 ` [PATCH 1/4] net: ipa: " Jeff Johnson
2022-09-12 23:25 ` [PATCH 2/4] remoteproc: sysmon: " Jeff Johnson
2022-09-12 23:25 ` [PATCH 3/4] slimbus: qcom-ngd-ctrl: " Jeff Johnson
2022-09-12 23:25 ` [PATCH 4/4] soc: qcom: pdr: " Jeff Johnson
2022-09-14 10:18 ` Sibi Sankar
2022-09-14 10:26 ` [PATCH 3/4] slimbus: qcom-ngd-ctrl: " Sibi Sankar
2022-09-16 13:06 ` Srinivas Kandagatla
2022-09-16 15:20 ` Jeff Johnson
2022-09-14 10:24 ` [PATCH 2/4] remoteproc: sysmon: " Sibi Sankar
2022-09-14 10:22 ` Sibi Sankar [this message]
2022-09-13 13:58 ` [PATCH 0/4] " Alex Elder
2022-09-13 18:51 ` Jeff Johnson
2022-09-13 20:21 ` Alex Elder
2022-09-13 22:19 ` Jeff Johnson
2022-09-15 18:47 ` Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 " Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 1/4] net: ipa: " Jeff Johnson
2022-10-18 21:17 ` [RESEND PATCH net-next] " Jeff Johnson
2022-10-21 12:20 ` patchwork-bot+netdevbpf
2022-09-14 23:47 ` [PATCH v2 2/4] remoteproc: sysmon: " Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 3/4] slimbus: qcom-ngd-ctrl: " Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 4/4] soc: qcom: pdr: " Jeff Johnson
2022-10-18 3:14 ` [PATCH v2 0/4] " Bjorn Andersson
2022-12-07 15:53 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe0283d-d2f4-a593-0748-a180e3589832@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jjohnson@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).