From: Alex Elder <elder@ieee.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
Alex Elder <elder@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Kalle Valo <kvalo@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Make QMI message rules const
Date: Tue, 13 Sep 2022 08:58:29 -0500 [thread overview]
Message-ID: <f2fa19a1-4854-b270-0776-38993dece03f@ieee.org> (raw)
In-Reply-To: <20220912232526.27427-1-quic_jjohnson@quicinc.com>
On 9/12/22 6:25 PM, Jeff Johnson wrote:
> Change ff6d365898d ("soc: qcom: qmi: use const for struct
> qmi_elem_info") allows QMI message encoding/decoding rules to be
> const. So now update the definitions in the various client to take
> advantage of this. Patches for ath10k and ath11k were perviously sent
> separately.
I have had this on my "to-do list" for ages.
The commit you mention updates the code to be
explicit about not modifying this data, which
is great.
I scanned over the changes, and I assume that
all you did was make every object having the
qmi_elem_info structure type be defined as
constant.
Why aren't you changing the "ei_array" field in
the qmi_elem_info structure to be const? Or the
"ei" field of the qmi_msg_handler structure? And
the qmi_response_type_v01_ei array (and so on)?
I like what you're doing, but can you comment
on what your plans are beyond this series?
Do you intend to make the rest of these fields
const?
Thanks.
-Alex
> This series depends upon:
> https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=ff6d365898d4d31bd557954c7fc53f38977b491c
>
> This is in the for-next banch of:
> git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git
>
> Hence this series is also based upon that tree/branch.
>
> Jeff Johnson (4):
> net: ipa: Make QMI message rules const
> remoteproc: sysmon: Make QMI message rules const
> slimbus: qcom-ngd-ctrl: Make QMI message rules const
> soc: qcom: pdr: Make QMI message rules const
>
> drivers/net/ipa/ipa_qmi_msg.c | 20 ++++++++++----------
> drivers/net/ipa/ipa_qmi_msg.h | 20 ++++++++++----------
> drivers/remoteproc/qcom_sysmon.c | 8 ++++----
> drivers/slimbus/qcom-ngd-ctrl.c | 8 ++++----
> drivers/soc/qcom/pdr_internal.h | 20 ++++++++++----------
> 5 files changed, 38 insertions(+), 38 deletions(-)
>
next prev parent reply other threads:[~2022-09-13 13:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 23:25 [PATCH 0/4] Make QMI message rules const Jeff Johnson
2022-09-12 23:25 ` [PATCH 1/4] net: ipa: " Jeff Johnson
2022-09-12 23:25 ` [PATCH 2/4] remoteproc: sysmon: " Jeff Johnson
2022-09-12 23:25 ` [PATCH 3/4] slimbus: qcom-ngd-ctrl: " Jeff Johnson
2022-09-12 23:25 ` [PATCH 4/4] soc: qcom: pdr: " Jeff Johnson
2022-09-14 10:18 ` Sibi Sankar
2022-09-14 10:26 ` [PATCH 3/4] slimbus: qcom-ngd-ctrl: " Sibi Sankar
2022-09-16 13:06 ` Srinivas Kandagatla
2022-09-16 15:20 ` Jeff Johnson
2022-09-14 10:24 ` [PATCH 2/4] remoteproc: sysmon: " Sibi Sankar
2022-09-14 10:22 ` [PATCH 1/4] net: ipa: " Sibi Sankar
2022-09-13 13:58 ` Alex Elder [this message]
2022-09-13 18:51 ` [PATCH 0/4] " Jeff Johnson
2022-09-13 20:21 ` Alex Elder
2022-09-13 22:19 ` Jeff Johnson
2022-09-15 18:47 ` Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 " Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 1/4] net: ipa: " Jeff Johnson
2022-10-18 21:17 ` [RESEND PATCH net-next] " Jeff Johnson
2022-10-21 12:20 ` patchwork-bot+netdevbpf
2022-09-14 23:47 ` [PATCH v2 2/4] remoteproc: sysmon: " Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 3/4] slimbus: qcom-ngd-ctrl: " Jeff Johnson
2022-09-14 23:47 ` [PATCH v2 4/4] soc: qcom: pdr: " Jeff Johnson
2022-10-18 3:14 ` [PATCH v2 0/4] " Bjorn Andersson
2022-12-07 15:53 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2fa19a1-4854-b270-0776-38993dece03f@ieee.org \
--to=elder@ieee.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jjohnson@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).