* [PATCH net-next] ipv6 mcast: Do not join device multicast for interface-local multicasts.
@ 2013-02-09 14:29 YOSHIFUJI Hideaki
2013-02-10 12:51 ` Hannes Frederic Sowa
2013-02-11 5:22 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YOSHIFUJI Hideaki @ 2013-02-09 14:29 UTC (permalink / raw)
To: netdev, David Miller; +Cc: YOSHIFUJI Hideaki
RFC4291 (IPv6 addressing architecture) says that interface-Local scope
spans only a single interface on a node. We should not join L2 device
multicast list for addresses in interface-local (or smaller) scope.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
---
net/ipv6/mcast.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index e5de4855..3a2849f 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -661,6 +661,10 @@ static void igmp6_group_added(struct ifmcaddr6 *mc)
struct net_device *dev = mc->idev->dev;
char buf[MAX_ADDR_LEN];
+ if (IPV6_ADDR_MC_SCOPE(&mc->mca_addr) <
+ IPV6_ADDR_SCOPE_LINKLOCAL)
+ return;
+
spin_lock_bh(&mc->mca_lock);
if (!(mc->mca_flags&MAF_LOADED)) {
mc->mca_flags |= MAF_LOADED;
@@ -687,6 +691,10 @@ static void igmp6_group_dropped(struct ifmcaddr6 *mc)
struct net_device *dev = mc->idev->dev;
char buf[MAX_ADDR_LEN];
+ if (IPV6_ADDR_MC_SCOPE(&mc->mca_addr) <
+ IPV6_ADDR_SCOPE_LINKLOCAL)
+ return;
+
spin_lock_bh(&mc->mca_lock);
if (mc->mca_flags&MAF_LOADED) {
mc->mca_flags &= ~MAF_LOADED;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6 mcast: Do not join device multicast for interface-local multicasts.
2013-02-09 14:29 [PATCH net-next] ipv6 mcast: Do not join device multicast for interface-local multicasts YOSHIFUJI Hideaki
@ 2013-02-10 12:51 ` Hannes Frederic Sowa
2013-02-11 5:22 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Frederic Sowa @ 2013-02-10 12:51 UTC (permalink / raw)
To: YOSHIFUJI Hideaki; +Cc: netdev, David Miller
On Sat, Feb 09, 2013 at 11:29:58PM +0900, YOSHIFUJI Hideaki wrote:
> RFC4291 (IPv6 addressing architecture) says that interface-Local scope
> spans only a single interface on a node. We should not join L2 device
> multicast list for addresses in interface-local (or smaller) scope.
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Had this patch in my tree while testing and it is definitely the right thing
to do:
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6 mcast: Do not join device multicast for interface-local multicasts.
2013-02-09 14:29 [PATCH net-next] ipv6 mcast: Do not join device multicast for interface-local multicasts YOSHIFUJI Hideaki
2013-02-10 12:51 ` Hannes Frederic Sowa
@ 2013-02-11 5:22 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-02-11 5:22 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Sat, 09 Feb 2013 23:29:58 +0900
> RFC4291 (IPv6 addressing architecture) says that interface-Local scope
> spans only a single interface on a node. We should not join L2 device
> multicast list for addresses in interface-local (or smaller) scope.
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-11 5:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-09 14:29 [PATCH net-next] ipv6 mcast: Do not join device multicast for interface-local multicasts YOSHIFUJI Hideaki
2013-02-10 12:51 ` Hannes Frederic Sowa
2013-02-11 5:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).