* [PATCH] sh_eth: use random MAC address if no valid one supplied
@ 2013-04-27 22:48 Sergei Shtylyov
2013-04-28 20:29 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2013-04-27 22:48 UTC (permalink / raw)
To: netdev; +Cc: nobuhiro.iwamatsu.yj, linux-sh
On Renesas R-Car based development boards, although a MAC address is printed on
all the Ethernet port labels, U-Boot doesn't write a valid MAC address to the
Ether MAHR/MALR registers (there's no storage provided for the Ether MAC address
either), so we have to resort to using a random MAC address...
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against the 'net-next.git' repository.
drivers/net/ethernet/renesas/sh_eth.c | 5 +++++
1 file changed, 5 insertions(+)
Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net-next/drivers/net/ethernet/renesas/sh_eth.c
@@ -2735,6 +2735,11 @@ static int sh_eth_drv_probe(struct platf
/* read and set MAC address */
read_mac_address(ndev, pd->mac_addr);
+ if (!is_valid_ether_addr(ndev->dev_addr)) {
+ dev_warn(&pdev->dev, "no valid MAC address supplied, using "
+ "a random one.\n");
+ eth_hw_addr_random(ndev);
+ }
/* ioremap the TSU registers */
if (mdp->cd->tsu) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh_eth: use random MAC address if no valid one supplied
2013-04-27 22:48 [PATCH] sh_eth: use random MAC address if no valid one supplied Sergei Shtylyov
@ 2013-04-28 20:29 ` Laurent Pinchart
2013-04-29 11:43 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2013-04-28 20:29 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, nobuhiro.iwamatsu.yj, linux-sh
Hi Sergei,
Thank you for the patch.
On Sunday 28 April 2013 02:48:11 Sergei Shtylyov wrote:
> On Renesas R-Car based development boards, although a MAC address is printed
> on all the Ethernet port labels, U-Boot doesn't write a valid MAC address
> to the Ether MAHR/MALR registers (there's no storage provided for the Ether
> MAC address either), so we have to resort to using a random MAC address...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'net-next.git' repository.
>
> drivers/net/ethernet/renesas/sh_eth.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
> ===================================================================
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2735,6 +2735,11 @@ static int sh_eth_drv_probe(struct platf
>
> /* read and set MAC address */
> read_mac_address(ndev, pd->mac_addr);
> + if (!is_valid_ether_addr(ndev->dev_addr)) {
> + dev_warn(&pdev->dev, "no valid MAC address supplied, using "
> + "a random one.\n");
Breaking log messages in the middle of a line is frowned upon, more than
exceeding the 80 characters per line (soft) limit. I think
dev_warn(&pdev->dev,
"no valid MAC address supplied, using a random one.\n");
would be better.
> + eth_hw_addr_random(ndev);
> + }
>
> /* ioremap the TSU registers */
> if (mdp->cd->tsu) {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh_eth: use random MAC address if no valid one supplied
2013-04-28 20:29 ` Laurent Pinchart
@ 2013-04-29 11:43 ` Sergei Shtylyov
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-04-29 11:43 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: netdev, nobuhiro.iwamatsu.yj, linux-sh
Hello.
On 29-04-2013 0:29, Laurent Pinchart wrote:
>> On Renesas R-Car based development boards, although a MAC address is printed
>> on all the Ethernet port labels, U-Boot doesn't write a valid MAC address
>> to the Ether MAHR/MALR registers (there's no storage provided for the Ether
>> MAC address either), so we have to resort to using a random MAC address...
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> This patch is against the 'net-next.git' repository.
>> drivers/net/ethernet/renesas/sh_eth.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
>> ===================================================================
>> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
>> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -2735,6 +2735,11 @@ static int sh_eth_drv_probe(struct platf
>>
>> /* read and set MAC address */
>> read_mac_address(ndev, pd->mac_addr);
>> + if (!is_valid_ether_addr(ndev->dev_addr)) {
>> + dev_warn(&pdev->dev, "no valid MAC address supplied, using "
>> + "a random one.\n");
> Breaking log messages in the middle of a line is frowned upon, more than
> exceeding the 80 characters per line (soft) limit. I think
> dev_warn(&pdev->dev,
> "no valid MAC address supplied, using a random one.\n");
> would be better.
Thanks, totally forgot about that when doing a patch, only remembered
after sending out.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-29 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-27 22:48 [PATCH] sh_eth: use random MAC address if no valid one supplied Sergei Shtylyov
2013-04-28 20:29 ` Laurent Pinchart
2013-04-29 11:43 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).