netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] remove vlan tags in CPSW dual emac mode
@ 2013-04-23 16:18 Markus Brunner
  2013-04-23 17:29 ` Mugunthan V N
  0 siblings, 1 reply; 10+ messages in thread
From: Markus Brunner @ 2013-04-23 16:18 UTC (permalink / raw)
  To: netdev, Mugunthan V N
  Cc: davem, linux-arm-kernel, linux-omap, Mark Jackson,
	systemprogrammierung.brunner

If operating in dual emac mode all packets sent by the CPSW contain vlan headers with the reserved VID 0, 
which gets stripped away by all somewhat recent Linux versions. Operating systems without that behaviour will fail to communicate. 
This patch fixes that behaviour by disabling the VLAN_AWARE mode as already described by the comment above.

Signed-off-by: Markus Brunner <systemprogrammierung.brunner@gmail.com>
Tested-by: Mark Jackson <mpfj@newflow.co.uk>

---
--- linux-3.9-rc8.orig/drivers/net/ethernet/ti/cpsw.c	2013-04-23 17:26:11.000000000 +0200
+++ linux-3.9-rc8/drivers/net/ethernet/ti/cpsw.c	2013-04-23 17:36:25.000000000 +0200
@@ -751,9 +751,9 @@ static void cpsw_init_host_port(struct c
 	/* switch to vlan unaware mode */
 	cpsw_ale_control_set(priv->ale, priv->host_port, ALE_VLAN_AWARE,
 			     CPSW_ALE_VLAN_AWARE);
 	control_reg = readl(&priv->regs->control);
-	control_reg |= CPSW_VLAN_AWARE;
+	control_reg &= ~CPSW_VLAN_AWARE;
 	writel(control_reg, &priv->regs->control);
 	fifo_mode = (priv->data.dual_emac) ? CPSW_FIFO_DUAL_MAC_MODE :
 		     CPSW_FIFO_NORMAL_MODE;
 	writel(fifo_mode, &priv->host_port_regs->tx_in_ctl);

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2013-07-19 18:07 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-23 16:18 [PATCH] remove vlan tags in CPSW dual emac mode Markus Brunner
2013-04-23 17:29 ` Mugunthan V N
2013-04-23 18:15   ` Mark Jackson
2013-07-12 13:57   ` Mark Jackson
2013-07-12 18:35     ` Mugunthan V N
2013-07-12 19:25       ` Mark Jackson
2013-07-15 12:45         ` Mugunthan V N
2013-07-15 15:50           ` Mark Jackson
2013-07-15 17:02             ` Mugunthan V N
2013-07-19 18:07               ` Markus Brunner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).