* [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare
@ 2013-12-28 6:18 Ding Tianhong
2013-12-28 6:59 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Ding Tianhong @ 2013-12-28 6:18 UTC (permalink / raw)
To: Dmitry Tarnyagin, David S. Miller, Netdev, linux-kernel
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
net/caif/cfrfml.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
index 61d7617..c680414 100644
--- a/net/caif/cfrfml.c
+++ b/net/caif/cfrfml.c
@@ -79,7 +79,7 @@ static struct cfpkt *rfm_append(struct cfrfml *rfml, char *seghead,
return NULL;
/* Verify correct header */
- if (memcmp(seghead, rfml->seghead, 6) != 0)
+ if (!ether_addr_equal(seghead, rfml->seghead))
return NULL;
tmppkt = cfpkt_append(rfml->incomplete_frm, pkt,
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare
2013-12-28 6:18 [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare Ding Tianhong
@ 2013-12-28 6:59 ` Joe Perches
2013-12-28 15:02 ` Ding Tianhong
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2013-12-28 6:59 UTC (permalink / raw)
To: Ding Tianhong, Sjur Brændeland
Cc: Dmitry Tarnyagin, David S. Miller, Netdev, linux-kernel
On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal
> to instead of memcmp.
This may be a distinction without difference, but
is a CAIF seghead also an ethernet address?
> diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
[]
> @@ -79,7 +79,7 @@ static struct cfpkt *rfm_append(struct cfrfml *rfml, char *seghead,
[]
> /* Verify correct header */
> - if (memcmp(seghead, rfml->seghead, 6) != 0)
> + if (!ether_addr_equal(seghead, rfml->seghead))
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare
2013-12-28 6:59 ` Joe Perches
@ 2013-12-28 15:02 ` Ding Tianhong
2013-12-28 17:04 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Ding Tianhong @ 2013-12-28 15:02 UTC (permalink / raw)
To: Joe Perches, Ding Tianhong, Sjur Brændeland
Cc: Dmitry Tarnyagin, David S. Miller, Netdev, linux-kernel
于 2013/12/28 14:59, Joe Perches 写道:
> On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
>> Use possibly more efficient ether_addr_equal
>> to instead of memcmp.
>
> This may be a distinction without difference, but
> is a CAIF seghead also an ethernet address?
>
NO,this is a coincidence, the CAIF seghead is 6 bytes too,
So from a logical point of view, maybe a new function with
suitable name will be more reasonable here, but the name of
ether_addr_equal is not correctly here.:)
thanks
Regards
Ding
>> diff --git a/net/caif/cfrfml.c b/net/caif/cfrfml.c
> []
>> @@ -79,7 +79,7 @@ static struct cfpkt *rfm_append(struct cfrfml *rfml, char *seghead,
> []
>> /* Verify correct header */
>> - if (memcmp(seghead, rfml->seghead, 6) != 0)
>> + if (!ether_addr_equal(seghead, rfml->seghead))
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare
2013-12-28 15:02 ` Ding Tianhong
@ 2013-12-28 17:04 ` Joe Perches
2013-12-30 2:14 ` Ding Tianhong
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2013-12-28 17:04 UTC (permalink / raw)
To: Ding Tianhong
Cc: Ding Tianhong, Dmitry Tarnyagin, David S. Miller, Netdev, linux-kernel
On Sat, 2013-12-28 at 23:02 +0800, Ding Tianhong wrote:
> 于 2013/12/28 14:59, Joe Perches 写道:
> > On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
> >> Use possibly more efficient ether_addr_equal
> >> to instead of memcmp.
> >
> > This may be a distinction without difference, but
> > is a CAIF seghead also an ethernet address?
> >
> NO,this is a coincidence, the CAIF seghead is 6 bytes too,
> So from a logical point of view, maybe a new function with
> suitable name will be more reasonable here, but the name of
> ether_addr_equal is not correctly here.:)
So please remove this one from the series.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare
2013-12-28 17:04 ` Joe Perches
@ 2013-12-30 2:14 ` Ding Tianhong
0 siblings, 0 replies; 5+ messages in thread
From: Ding Tianhong @ 2013-12-30 2:14 UTC (permalink / raw)
To: Joe Perches, Ding Tianhong
Cc: Dmitry Tarnyagin, David S. Miller, Netdev, linux-kernel
On 2013/12/29 1:04, Joe Perches wrote:
> On Sat, 2013-12-28 at 23:02 +0800, Ding Tianhong wrote:
>> 于 2013/12/28 14:59, Joe Perches 写道:
>>> On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
>>>> Use possibly more efficient ether_addr_equal
>>>> to instead of memcmp.
>>>
>>> This may be a distinction without difference, but
>>> is a CAIF seghead also an ethernet address?
>>>
>> NO,this is a coincidence, the CAIF seghead is 6 bytes too,
>> So from a logical point of view, maybe a new function with
>> suitable name will be more reasonable here, but the name of
>> ether_addr_equal is not correctly here.:)
>
> So please remove this one from the series.
>
>
Yes, Ok!
Regards
Ding
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-30 2:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-28 6:18 [PATCH net-next v2 20/20] net: caif: slight optimization of addr compare Ding Tianhong
2013-12-28 6:59 ` Joe Perches
2013-12-28 15:02 ` Ding Tianhong
2013-12-28 17:04 ` Joe Perches
2013-12-30 2:14 ` Ding Tianhong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).