* [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()
@ 2022-05-30 11:34 Juergen Gross
2022-05-30 11:52 ` Jan Beulich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Juergen Gross @ 2022-05-30 11:34 UTC (permalink / raw)
To: xen-devel, netdev, linux-kernel
Cc: Juergen Gross, Wei Liu, Paul Durrant, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jan Beulich
Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case
of RING_HAS_UNCONSUMED_REQUESTS().
Reported-by: Jan Beulich <jbeulich@suse.com>
Fixes: 6fac592cca60 ("xen: update ring.h")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/net/xen-netback/netback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 0f7fd159f0f2..d93814c14a23 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -828,7 +828,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
break;
}
- work_to_do = RING_HAS_UNCONSUMED_REQUESTS(&queue->tx);
+ work_to_do = XEN_RING_NR_UNCONSUMED_REQUESTS(&queue->tx);
if (!work_to_do)
break;
--
2.35.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()
2022-05-30 11:34 [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() Juergen Gross
@ 2022-05-30 11:52 ` Jan Beulich
2022-05-30 13:38 ` Wei Liu
2022-05-31 13:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2022-05-30 11:52 UTC (permalink / raw)
To: Juergen Gross
Cc: Wei Liu, Paul Durrant, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, xen-devel, netdev, linux-kernel
On 30.05.2022 13:34, Juergen Gross wrote:
> Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case
> of RING_HAS_UNCONSUMED_REQUESTS().
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: 6fac592cca60 ("xen: update ring.h")
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()
2022-05-30 11:34 [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() Juergen Gross
2022-05-30 11:52 ` Jan Beulich
@ 2022-05-30 13:38 ` Wei Liu
2022-05-31 13:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Wei Liu @ 2022-05-30 13:38 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, netdev, linux-kernel, Wei Liu, Paul Durrant,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Jan Beulich
On Mon, May 30, 2022 at 01:34:59PM +0200, Juergen Gross wrote:
> Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case
> of RING_HAS_UNCONSUMED_REQUESTS().
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: 6fac592cca60 ("xen: update ring.h")
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wei.liu@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()
2022-05-30 11:34 [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() Juergen Gross
2022-05-30 11:52 ` Jan Beulich
2022-05-30 13:38 ` Wei Liu
@ 2022-05-31 13:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-31 13:10 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, netdev, linux-kernel, wei.liu, paul, davem, edumazet,
kuba, pabeni, jbeulich
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 30 May 2022 13:34:59 +0200 you wrote:
> Commit 6fac592cca60 ("xen: update ring.h") missed to fix one use case
> of RING_HAS_UNCONSUMED_REQUESTS().
>
> Reported-by: Jan Beulich <jbeulich@suse.com>
> Fixes: 6fac592cca60 ("xen: update ring.h")
> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> [...]
Here is the summary with links:
- xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS()
https://git.kernel.org/netdev/net/c/09e545f73814
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-31 13:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-30 11:34 [PATCH] xen/netback: fix incorrect usage of RING_HAS_UNCONSUMED_REQUESTS() Juergen Gross
2022-05-30 11:52 ` Jan Beulich
2022-05-30 13:38 ` Wei Liu
2022-05-31 13:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).