From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: filter: use block statements in tcpdump tests
Date: Tue, 27 May 2014 19:00:13 +0200 [thread overview]
Message-ID: <5384C49D.7090101@redhat.com> (raw)
In-Reply-To: <CAMEtUuwDsabgox593uiDNocBgLo=LFE34ByqLkF0iA+F7X=boQ@mail.gmail.com>
On 05/27/2014 08:20 AM, Alexei Starovoitov wrote:
...
>> + BPF_STMT(BPF_ALU | BPF_LSH | BPF_K, 2),
>> + BPF_STMT(BPF_MISC | BPF_TAX, 0x5), /* libpcap emits K on TAX */
>
> interesting observation. It means that libpcap doesn't init memory
> properly and other fields just have junk in them?
> and because it was doing it forever we need to accept such 'valid'
> instructions? Oh well. ok.
Hmm, doesn't look like totally random. Perhaps they're
storing some intermediate value in it or something, and
don't clear that out as we have accepted that since ever,
but that shouldn't do anything anyway here. ;)
next prev parent reply other threads:[~2014-05-27 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 18:17 [PATCH net-next 0/2] BPF test suite update Daniel Borkmann
2014-05-26 18:17 ` [PATCH net-next 1/2] net: filter: test fill/spill of all M[] regs Daniel Borkmann
2014-05-27 6:02 ` Alexei Starovoitov
2014-05-27 16:57 ` Daniel Borkmann
2014-05-26 18:17 ` [PATCH net-next 2/2] net: filter: use block statements in tcpdump tests Daniel Borkmann
2014-05-27 6:20 ` Alexei Starovoitov
2014-05-27 17:00 ` Daniel Borkmann [this message]
2014-05-30 23:27 ` [PATCH net-next 0/2] BPF test suite update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5384C49D.7090101@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).