From: Alexei Starovoitov <ast@plumgrid.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: filter: test fill/spill of all M[] regs
Date: Mon, 26 May 2014 23:02:51 -0700 [thread overview]
Message-ID: <CAMEtUuyP+F5SxBnaT7a3LgAwcp5MG6knWEsdt1-xdq2pk2gWxQ@mail.gmail.com> (raw)
In-Reply-To: <1401128255-6545-2-git-send-email-dborkman@redhat.com>
On Mon, May 26, 2014 at 11:17 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
> This test for classic BPF probes stores and load combination
> via X on all 16 registers of the scratch memory store. It
> initially loads integer 100 and passes this value around
> to each register while incrementing it every time, thus we
> expect to have 116 as a result. Might be useful for JIT
> testing.
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Looks good. The more tests the better.
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
> ---
> lib/test_bpf.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 90 insertions(+)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index af677cb..6be9119 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -1485,6 +1485,96 @@ static struct bpf_test tests[] = {
> { },
> { },
> },
> + { /* Mainly checking JIT here. */
> + "M[]: STX + LDX",
> + .u.insns = {
> + BPF_STMT(BPF_LDX | BPF_IMM, 100),
> + BPF_STMT(BPF_STX, 0),
> + BPF_STMT(BPF_LDX | BPF_MEM, 0),
store and immediate load from the same slot won't catch slot overlap,
but that would be a job for another test.
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 1),
> + BPF_STMT(BPF_LDX | BPF_MEM, 1),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 2),
> + BPF_STMT(BPF_LDX | BPF_MEM, 2),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 3),
> + BPF_STMT(BPF_LDX | BPF_MEM, 3),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 4),
> + BPF_STMT(BPF_LDX | BPF_MEM, 4),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 5),
> + BPF_STMT(BPF_LDX | BPF_MEM, 5),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 6),
> + BPF_STMT(BPF_LDX | BPF_MEM, 6),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 7),
> + BPF_STMT(BPF_LDX | BPF_MEM, 7),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 8),
> + BPF_STMT(BPF_LDX | BPF_MEM, 8),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 9),
> + BPF_STMT(BPF_LDX | BPF_MEM, 9),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 10),
> + BPF_STMT(BPF_LDX | BPF_MEM, 10),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 11),
> + BPF_STMT(BPF_LDX | BPF_MEM, 11),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 12),
> + BPF_STMT(BPF_LDX | BPF_MEM, 12),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 13),
> + BPF_STMT(BPF_LDX | BPF_MEM, 13),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 14),
> + BPF_STMT(BPF_LDX | BPF_MEM, 14),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_STX, 15),
> + BPF_STMT(BPF_LDX | BPF_MEM, 15),
> + BPF_STMT(BPF_MISC | BPF_TXA, 0),
> + BPF_STMT(BPF_ALU | BPF_ADD | BPF_K, 1),
> + BPF_STMT(BPF_MISC | BPF_TAX, 0),
> + BPF_STMT(BPF_RET | BPF_A, 0),
> + },
> + CLASSIC | FLAG_NO_DATA,
> + { },
> + { { 0, 116 } },
> + },
> };
>
> static struct net_device dev;
> --
> 1.7.11.7
>
next prev parent reply other threads:[~2014-05-27 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 18:17 [PATCH net-next 0/2] BPF test suite update Daniel Borkmann
2014-05-26 18:17 ` [PATCH net-next 1/2] net: filter: test fill/spill of all M[] regs Daniel Borkmann
2014-05-27 6:02 ` Alexei Starovoitov [this message]
2014-05-27 16:57 ` Daniel Borkmann
2014-05-26 18:17 ` [PATCH net-next 2/2] net: filter: use block statements in tcpdump tests Daniel Borkmann
2014-05-27 6:20 ` Alexei Starovoitov
2014-05-27 17:00 ` Daniel Borkmann
2014-05-30 23:27 ` [PATCH net-next 0/2] BPF test suite update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMEtUuyP+F5SxBnaT7a3LgAwcp5MG6knWEsdt1-xdq2pk2gWxQ@mail.gmail.com \
--to=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).