* [PATCH resend] ip: add nlmon as a device type to help message
@ 2014-06-11 19:08 Masatake YAMATO
2014-06-11 21:53 ` Daniel Borkmann
0 siblings, 1 reply; 6+ messages in thread
From: Masatake YAMATO @ 2014-06-11 19:08 UTC (permalink / raw)
To: netdev; +Cc: yamato
Though nlmon device can be added, it was not listed
in the output of "ip link help".
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
ip/iplink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index 0d020ef..ce5aa81 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -87,7 +87,7 @@ void iplink_usage(void)
fprintf(stderr, "\n");
fprintf(stderr, "TYPE := { vlan | veth | vcan | dummy | ifb | macvlan | macvtap |\n");
fprintf(stderr, " bridge | bond | ipoib | ip6tnl | ipip | sit | vxlan |\n");
- fprintf(stderr, " gre | gretap | ip6gre | ip6gretap | vti }\n");
+ fprintf(stderr, " gre | gretap | ip6gre | ip6gretap | vti | nlmon }\n");
}
exit(-1);
}
--
1.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH resend] ip: add nlmon as a device type to help message
2014-06-11 19:08 [PATCH resend] ip: add nlmon as a device type to help message Masatake YAMATO
@ 2014-06-11 21:53 ` Daniel Borkmann
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Borkmann @ 2014-06-11 21:53 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: netdev
On 06/11/2014 09:08 PM, Masatake YAMATO wrote:
> Though nlmon device can be added, it was not listed
> in the output of "ip link help".
>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] ip: add nlmon as a device type to help message
2014-07-15 8:57 Masatake YAMATO
2014-07-15 9:29 ` Daniel Borkmann
@ 2014-07-15 16:42 ` Stephen Hemminger
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2014-07-15 16:42 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: netdev
On Tue, 15 Jul 2014 17:57:16 +0900
Masatake YAMATO <yamato@redhat.com> wrote:
> Though nlmon device can be added, it was not listed
> in the output of "ip link help".
>
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> ---
> ip/iplink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/iplink.c b/ip/iplink.c
> index de9ef5d..5e428da 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -87,7 +87,7 @@ void iplink_usage(void)
> fprintf(stderr, "\n");
> fprintf(stderr, "TYPE := { vlan | veth | vcan | dummy | ifb | macvlan | macvtap |\n");
> fprintf(stderr, " bridge | bond | ipoib | ip6tnl | ipip | sit | vxlan |\n");
> - fprintf(stderr, " gre | gretap | ip6gre | ip6gretap | vti }\n");
> + fprintf(stderr, " gre | gretap | ip6gre | ip6gretap | vti | nlmon }\n");
> }
> exit(-1);
> }
accepted
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] ip: add nlmon as a device type to help message
2014-07-15 9:29 ` Daniel Borkmann
@ 2014-07-15 9:55 ` Masatake YAMATO
0 siblings, 0 replies; 6+ messages in thread
From: Masatake YAMATO @ 2014-07-15 9:55 UTC (permalink / raw)
To: dborkman; +Cc: netdev
> On 07/15/2014 10:57 AM, Masatake YAMATO wrote:
>> Though nlmon device can be added, it was not listed
>> in the output of "ip link help".
>>
>> Acked-by: Daniel Borkmann <dborkman@redhat.com>
>> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
>
> No need to resend, your original patch is still queued
> up here: http://patchwork.ozlabs.org/patch/358864/
Oh, sorry. I don't know that. Thank you.
Masaake YAMATO
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] ip: add nlmon as a device type to help message
2014-07-15 8:57 Masatake YAMATO
@ 2014-07-15 9:29 ` Daniel Borkmann
2014-07-15 9:55 ` Masatake YAMATO
2014-07-15 16:42 ` Stephen Hemminger
1 sibling, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2014-07-15 9:29 UTC (permalink / raw)
To: Masatake YAMATO; +Cc: netdev
On 07/15/2014 10:57 AM, Masatake YAMATO wrote:
> Though nlmon device can be added, it was not listed
> in the output of "ip link help".
>
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
No need to resend, your original patch is still queued
up here: http://patchwork.ozlabs.org/patch/358864/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH resend] ip: add nlmon as a device type to help message
@ 2014-07-15 8:57 Masatake YAMATO
2014-07-15 9:29 ` Daniel Borkmann
2014-07-15 16:42 ` Stephen Hemminger
0 siblings, 2 replies; 6+ messages in thread
From: Masatake YAMATO @ 2014-07-15 8:57 UTC (permalink / raw)
To: netdev; +Cc: yamato
Though nlmon device can be added, it was not listed
in the output of "ip link help".
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
ip/iplink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index de9ef5d..5e428da 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -87,7 +87,7 @@ void iplink_usage(void)
fprintf(stderr, "\n");
fprintf(stderr, "TYPE := { vlan | veth | vcan | dummy | ifb | macvlan | macvtap |\n");
fprintf(stderr, " bridge | bond | ipoib | ip6tnl | ipip | sit | vxlan |\n");
- fprintf(stderr, " gre | gretap | ip6gre | ip6gretap | vti }\n");
+ fprintf(stderr, " gre | gretap | ip6gre | ip6gretap | vti | nlmon }\n");
}
exit(-1);
}
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-15 16:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-11 19:08 [PATCH resend] ip: add nlmon as a device type to help message Masatake YAMATO
2014-06-11 21:53 ` Daniel Borkmann
2014-07-15 8:57 Masatake YAMATO
2014-07-15 9:29 ` Daniel Borkmann
2014-07-15 9:55 ` Masatake YAMATO
2014-07-15 16:42 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).