* [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash key
@ 2014-07-22 12:21 Venkat Duvvuru
2014-07-31 7:43 ` Venkat Duvvuru
0 siblings, 1 reply; 4+ messages in thread
From: Venkat Duvvuru @ 2014-07-22 12:21 UTC (permalink / raw)
To: ben; +Cc: netdev, Venkat Duvvuru
NIC drivers that support RSS use either a hard-coded value or a random value
for the RSS hash key. Irrespective of the type of the key used, the user
would want to change the hash key if he/she is not satisfied with the
effectiveness of the default hash-key in spreading the incoming flows evenly
across the RSS queues.
This patch set adds support for configuring the RSS hash-key via the ethtool
interface using -X/-x option.
v7:
1. Changed rss string to RSS to be consistent with other parts of the error codes
and documentation.
2. Corrected a few error messages
3. Changed error codes to use either 1 or 2 based on the situation
4. Added test cases in test-cmdline.c
Venkat Duvvuru (2):
ethtool: Support for configurable RSS hash key.
ethtool: Support for configurable RSS hash key.
ethtool-copy.h | 478 ++++++++++++++++++++++++++++++++++++++++++--------------
ethtool.8.in | 18 ++-
ethtool.c | 393 +++++++++++++++++++++++++++++++++++++++--------
test-cmdline.c | 11 ++
4 files changed, 717 insertions(+), 183 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash key
2014-07-22 12:21 [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash key Venkat Duvvuru
@ 2014-07-31 7:43 ` Venkat Duvvuru
2014-08-11 7:02 ` Ivan Vecera
0 siblings, 1 reply; 4+ messages in thread
From: Venkat Duvvuru @ 2014-07-31 7:43 UTC (permalink / raw)
To: ben; +Cc: netdev
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Venkat Duvvuru
> Sent: Tuesday, July 22, 2014 5:51 PM
> To: ben@decadent.org.uk
> Cc: netdev@vger.kernel.org; Venkat Duvvuru
> Subject: [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash
> key
>
> NIC drivers that support RSS use either a hard-coded value or a random value
> for the RSS hash key. Irrespective of the type of the key used, the user
> would want to change the hash key if he/she is not satisfied with the
> effectiveness of the default hash-key in spreading the incoming flows evenly
> across the RSS queues.
>
> This patch set adds support for configuring the RSS hash-key via the ethtool
> interface using -X/-x option.
>
> v7:
> 1. Changed rss string to RSS to be consistent with other parts of the error
> codes
> and documentation.
> 2. Corrected a few error messages
> 3. Changed error codes to use either 1 or 2 based on the situation
> 4. Added test cases in test-cmdline.c
>
> Venkat Duvvuru (2):
> ethtool: Support for configurable RSS hash key.
> ethtool: Support for configurable RSS hash key.
>
> ethtool-copy.h | 478
> ++++++++++++++++++++++++++++++++++++++++++--------------
> ethtool.8.in | 18 ++-
> ethtool.c | 393 +++++++++++++++++++++++++++++++++++++++--------
> test-cmdline.c | 11 ++
> 4 files changed, 717 insertions(+), 183 deletions(-)
Ben, Please let me know if you have any further comments on this.
/Venkat.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash key
2014-07-31 7:43 ` Venkat Duvvuru
@ 2014-08-11 7:02 ` Ivan Vecera
2014-09-17 8:55 ` Ivan Vecera
0 siblings, 1 reply; 4+ messages in thread
From: Ivan Vecera @ 2014-08-11 7:02 UTC (permalink / raw)
To: ben; +Cc: Venkat Duvvuru, netdev
On 31.7.2014 09:43, Venkat Duvvuru wrote:
>
>
>> -----Original Message-----
>> From: netdev-owner@vger.kernel.org [mailto:netdev-
>> owner@vger.kernel.org] On Behalf Of Venkat Duvvuru
>> Sent: Tuesday, July 22, 2014 5:51 PM
>> To: ben@decadent.org.uk
>> Cc: netdev@vger.kernel.org; Venkat Duvvuru
>> Subject: [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash
>> key
>>
>> NIC drivers that support RSS use either a hard-coded value or a random value
>> for the RSS hash key. Irrespective of the type of the key used, the user
>> would want to change the hash key if he/she is not satisfied with the
>> effectiveness of the default hash-key in spreading the incoming flows evenly
>> across the RSS queues.
>>
>> This patch set adds support for configuring the RSS hash-key via the ethtool
>> interface using -X/-x option.
>>
>> v7:
>> 1. Changed rss string to RSS to be consistent with other parts of the error
>> codes
>> and documentation.
>> 2. Corrected a few error messages
>> 3. Changed error codes to use either 1 or 2 based on the situation
>> 4. Added test cases in test-cmdline.c
>>
>> Venkat Duvvuru (2):
>> ethtool: Support for configurable RSS hash key.
>> ethtool: Support for configurable RSS hash key.
>>
>> ethtool-copy.h | 478
>> ++++++++++++++++++++++++++++++++++++++++++--------------
>> ethtool.8.in | 18 ++-
>> ethtool.c | 393 +++++++++++++++++++++++++++++++++++++++--------
>> test-cmdline.c | 11 ++
>> 4 files changed, 717 insertions(+), 183 deletions(-)
>
> Ben, Please let me know if you have any further comments on this.
>
> /Venkat.
Hi Ben,
any objection?
Ivan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash key
2014-08-11 7:02 ` Ivan Vecera
@ 2014-09-17 8:55 ` Ivan Vecera
0 siblings, 0 replies; 4+ messages in thread
From: Ivan Vecera @ 2014-09-17 8:55 UTC (permalink / raw)
To: ben; +Cc: Venkat Duvvuru, netdev
On 11.8.2014 09:02, Ivan Vecera wrote:
> On 31.7.2014 09:43, Venkat Duvvuru wrote:
>>
>>
>>> -----Original Message-----
>>> From: netdev-owner@vger.kernel.org [mailto:netdev-
>>> owner@vger.kernel.org] On Behalf Of Venkat Duvvuru
>>> Sent: Tuesday, July 22, 2014 5:51 PM
>>> To: ben@decadent.org.uk
>>> Cc: netdev@vger.kernel.org; Venkat Duvvuru
>>> Subject: [PATCH v7 ethtool 0/2] patchset - Support for configurable
>>> RSS hash
>>> key
>>>
>>> NIC drivers that support RSS use either a hard-coded value or a
>>> random value
>>> for the RSS hash key. Irrespective of the type of the key used, the user
>>> would want to change the hash key if he/she is not satisfied with the
>>> effectiveness of the default hash-key in spreading the incoming flows
>>> evenly
>>> across the RSS queues.
>>>
>>> This patch set adds support for configuring the RSS hash-key via the
>>> ethtool
>>> interface using -X/-x option.
>>>
>>> v7:
>>> 1. Changed rss string to RSS to be consistent with other parts of the
>>> error
>>> codes
>>> and documentation.
>>> 2. Corrected a few error messages
>>> 3. Changed error codes to use either 1 or 2 based on the situation
>>> 4. Added test cases in test-cmdline.c
>>>
>>> Venkat Duvvuru (2):
>>> ethtool: Support for configurable RSS hash key.
>>> ethtool: Support for configurable RSS hash key.
>>>
>>> ethtool-copy.h | 478
>>> ++++++++++++++++++++++++++++++++++++++++++--------------
>>> ethtool.8.in | 18 ++-
>>> ethtool.c | 393 +++++++++++++++++++++++++++++++++++++++--------
>>> test-cmdline.c | 11 ++
>>> 4 files changed, 717 insertions(+), 183 deletions(-)
>>
>> Ben, Please let me know if you have any further comments on this.
>>
>> /Venkat.
> Hi Ben,
> any objection?
>
> Ivan
Ben, is there any problem with this??
Ivan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-17 8:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-22 12:21 [PATCH v7 ethtool 0/2] patchset - Support for configurable RSS hash key Venkat Duvvuru
2014-07-31 7:43 ` Venkat Duvvuru
2014-08-11 7:02 ` Ivan Vecera
2014-09-17 8:55 ` Ivan Vecera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).