From: Krzysztof Kolasa <kkolasa@winsoft.pl>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Cong Wang <cwang@twopensource.com>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses
Date: Wed, 15 Oct 2014 12:35:04 +0200 [thread overview]
Message-ID: <543E4DD8.80203@winsoft.pl> (raw)
In-Reply-To: <1413323024.17109.11.camel@edumazet-glaptop2.roam.corp.google.com>
W dniu 14.10.2014 o 23:43, Eric Dumazet pisze:
> On Tue, 2014-10-14 at 14:24 -0700, Cong Wang wrote:
>
>> Since we are still in merge window, I don't think we have to use
>> a one-line fix for a bug introduced in this merge window.
> You are clearly refactoring here. Its a nice cleanup.
>
> If I was the maintainer, I would prefer the one line fix.
>
> Then when net-next is open, you refactor.
>
> As I said, I wont argue, do whatever you want.
>
> Thanks
>
>
>
one-line patch not resolve problem, fix created by Cong Wang resolves
problem !!!
tested on 64bit system and working OK
next prev parent reply other threads:[~2014-10-15 10:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 17:11 something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses Krzysztof Kolasa
2014-10-12 18:46 ` Eric Dumazet
2014-10-13 23:59 ` Cong Wang
2014-10-14 0:09 ` Cong Wang
2014-10-14 13:25 ` Krzysztof Kolasa
2014-10-14 18:59 ` Cong Wang
2014-10-14 19:03 ` David Miller
[not found] ` <CAFrEnehWNzmzZGV-ZGbZF=wJ1q0TjFtB1yG6Dp1yVrJmBj9B7Q@mail.gmail.com>
2014-10-14 20:47 ` David Miller
2014-10-14 21:03 ` Eric Dumazet
2014-10-14 21:15 ` David Miller
2014-10-14 21:24 ` Cong Wang
2014-10-14 21:43 ` Eric Dumazet
2014-10-15 10:35 ` Krzysztof Kolasa [this message]
2014-10-15 11:27 ` Eric Dumazet
2014-10-15 11:40 ` Krzysztof Kolasa
2014-10-15 15:32 ` Eric Dumazet
2014-10-15 20:20 ` Krzysztof Kolasa
2014-10-15 20:36 ` Cong Wang
2014-10-15 20:42 ` Krzysztof Kolasa
2014-10-15 21:22 ` Cong Wang
2014-10-15 21:25 ` Cong Wang
2014-10-15 21:39 ` Eric Dumazet
2014-10-15 21:42 ` Eric Dumazet
2014-10-17 19:29 ` David Miller
2014-10-17 19:48 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543E4DD8.80203@winsoft.pl \
--to=kkolasa@winsoft.pl \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=edumazet@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).