netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <cwang@twopensource.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Krzysztof Kolasa <kkolasa@winsoft.pl>,
	netdev <netdev@vger.kernel.org>,
	edumazet@gmail.com, David Miller <davem@davemloft.net>
Subject: Re: something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses
Date: Mon, 13 Oct 2014 17:09:37 -0700	[thread overview]
Message-ID: <CAHA+R7NOvmyDo_Up32z1oJKCEmCqywRyTkbio4i4n1J+bNg4Cw@mail.gmail.com> (raw)
In-Reply-To: <CAHA+R7OWpjO0AbwteOAfxd1fej6BcjXR99xy+MnkZ8y+JZ8f4g@mail.gmail.com>

On Mon, Oct 13, 2014 at 4:59 PM, Cong Wang <cwang@twopensource.com> wrote:
> Probably not related with this bug, but with regarding to the
> offending commit, what's the point of the memmove() in tcp_v4_rcv()
> since ip_rcv() already clears IPCB()?

Oh, ip options are actually saved in ip_rcv_finish()... Hmm, looks scary
to play with variable-length array with memmove()....

  reply	other threads:[~2014-10-14  0:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12 17:11 something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses Krzysztof Kolasa
2014-10-12 18:46 ` Eric Dumazet
2014-10-13 23:59   ` Cong Wang
2014-10-14  0:09     ` Cong Wang [this message]
2014-10-14 13:25       ` Krzysztof Kolasa
2014-10-14 18:59         ` Cong Wang
2014-10-14 19:03           ` David Miller
     [not found]             ` <CAFrEnehWNzmzZGV-ZGbZF=wJ1q0TjFtB1yG6Dp1yVrJmBj9B7Q@mail.gmail.com>
2014-10-14 20:47               ` David Miller
2014-10-14 21:03                 ` Eric Dumazet
2014-10-14 21:15                   ` David Miller
2014-10-14 21:24                     ` Cong Wang
2014-10-14 21:43                       ` Eric Dumazet
2014-10-15 10:35                         ` Krzysztof Kolasa
2014-10-15 11:27                           ` Eric Dumazet
2014-10-15 11:40                             ` Krzysztof Kolasa
2014-10-15 15:32                               ` Eric Dumazet
2014-10-15 20:20                                 ` Krzysztof Kolasa
2014-10-15 20:36                           ` Cong Wang
2014-10-15 20:42                             ` Krzysztof Kolasa
2014-10-15 21:22                               ` Cong Wang
2014-10-15 21:25                                 ` Cong Wang
2014-10-15 21:39                             ` Eric Dumazet
2014-10-15 21:42                               ` Eric Dumazet
2014-10-17 19:29                                 ` David Miller
2014-10-17 19:48                                   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHA+R7NOvmyDo_Up32z1oJKCEmCqywRyTkbio4i4n1J+bNg4Cw@mail.gmail.com \
    --to=cwang@twopensource.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kkolasa@winsoft.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).