From: Nikolay Aleksandrov <razor@blackwall.org>
To: Jonathan Toppins <jtoppins@cumulusnetworks.com>,
netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <gospo@cumulusnetworks.com>,
shm@cumulusnetworks.com, David Miller <davem@davemloft.net>
Subject: Re: [PATCH linux v3 net-next 4/4] bonding: add netlink support for sys prio, actor sys mac, and port key
Date: Sun, 10 May 2015 09:54:15 +0200 [thread overview]
Message-ID: <554F0EA7.4060000@blackwall.org> (raw)
In-Reply-To: <c26a9459226784190a8503418c1375bfe1f90cae.1431150701.git.jtoppins@cumulusnetworks.com>
On 09/05/15 09:01, Jonathan Toppins wrote:
> From: Andy Gospodarek <gospo@cumulusnetworks.com>
>
> Adds netlink support for the following bonding options:
> * BOND_OPT_AD_ACTOR_SYS_PRIO
> * BOND_OPT_AD_ACTOR_SYSTEM
> * BOND_OPT_AD_USER_PORT_KEY
>
> When setting the actor system mac address we assume the netlink message
> contains a binary mac and not a string representation of a mac.
>
> Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
> [jt: completed the setting side of the netlink attributes]
> Signed-off-by: Jonathan Toppins <jtoppins@cumulusnetworks.com>
> ---
> v2:
> * rebased
> v3:
> * removed parenthesis from around values in the netdev_info calls in
> bond_option_ad_actor_sys_prio_set() and
> bond_option_ad_user_port_key_set()
> * fixed up bond_option_ad_actor_system_set() to support handling both
> string and value setting as Nik suggested
>
> drivers/net/bonding/bond_netlink.c | 50 ++++++++++++++++++++++++++++++++++++
> drivers/net/bonding/bond_options.c | 30 +++++++++++++++-------
> include/uapi/linux/if_link.h | 3 +++
> 3 files changed, 74 insertions(+), 9 deletions(-)
>
>
Thank you for re-working this, it actually looks better than I thought it
would. I'm traveling right now and can't test it, but I went over the patch
and it looks good to me.
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2015-05-10 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 7:01 [PATCH linux v3 net-next 0/5] add netlink support for new lacp bonding parameters Jonathan Toppins
2015-05-09 7:01 ` [PATCH linux v3 net-next 1/4] bonding: Allow userspace to set actors' system_priority in AD system Jonathan Toppins
2015-05-09 7:01 ` [PATCH linux v3 net-next 2/4] bonding: Allow userspace to set actors' macaddr in an AD-system Jonathan Toppins
2015-05-09 7:01 ` [PATCH linux v3 net-next 3/4] bonding: Implement user key part of port_key in an AD system Jonathan Toppins
2015-05-09 7:01 ` [PATCH linux v3 net-next 4/4] bonding: add netlink support for sys prio, actor sys mac, and port key Jonathan Toppins
2015-05-10 7:54 ` Nikolay Aleksandrov [this message]
2015-05-09 7:01 ` [PATCH iproute2 v3 net-next] iplink_bond: add support for ad_actor and port_key options Jonathan Toppins
2015-05-21 22:27 ` Stephen Hemminger
2015-05-11 15:00 ` [PATCH linux v3 net-next 0/5] add netlink support for new lacp bonding parameters David Miller
2015-05-11 15:50 ` Jonathan Toppins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554F0EA7.4060000@blackwall.org \
--to=razor@blackwall.org \
--cc=davem@davemloft.net \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=jtoppins@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=shm@cumulusnetworks.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).