* RESEND: Performance loss due to commit 37c3185 ([NET]: Added GSO toggle)
@ 2015-06-25 14:57 leroy christophe
0 siblings, 0 replies; only message in thread
From: leroy christophe @ 2015-06-25 14:57 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev, David S. Miller, linux-crypto
Hello Herbert,
In commit "[NET]: Added GSO toggle"
37c3185a02d4b85fbe134bf5204535405dd2c957,
you force NETIF_F_HW_CSUM if GSO feature is selected.
By default, SW GSO is active as soon as a network board has NETIF_F_SG
feature.
This means that function sk_setup_caps() forces NETIF_F_HW_CSUM for any
board having NETIF_F_SG
For boards having no HW checksum capability, this results in performance
loss due to data copy being done in skb_do_copy_data_nocache() with
copy_from_user() then checksum being done later with csum_partial()
instead of getting both done at the same time using
csum_and_copy_from_user()
What is the reason for forcing NETIF_F_HW_CSUM ?
Christophe
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-25 14:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-25 14:57 RESEND: Performance loss due to commit 37c3185 ([NET]: Added GSO toggle) leroy christophe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).