* [PATCH] net, can, ti_hecc: fix a run time warn_on.
@ 2015-10-19 6:22 Heiko Schocher
2015-10-19 6:34 ` Marc Kleine-Budde
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Schocher @ 2015-10-19 6:22 UTC (permalink / raw)
To: linux-kernel
Cc: Heiko Schocher, netdev, linux-can, Marc Kleine-Budde,
Wolfgang Grandegger
This patch fixes a warning in clk_enable by calling
clk_prepare_enable instead.
Signed-off-by: Heiko Schocher <hs@denx.de>
---
drivers/net/can/ti_hecc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index cf345cb..c08e8ea 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll,
HECC_DEF_NAPI_WEIGHT);
- clk_enable(priv->clk);
+ clk_prepare_enable(priv->clk);
err = register_candev(ndev);
if (err) {
dev_err(&pdev->dev, "register_candev() failed\n");
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net, can, ti_hecc: fix a run time warn_on.
2015-10-19 6:22 [PATCH] net, can, ti_hecc: fix a run time warn_on Heiko Schocher
@ 2015-10-19 6:34 ` Marc Kleine-Budde
2015-10-19 6:51 ` Heiko Schocher
0 siblings, 1 reply; 3+ messages in thread
From: Marc Kleine-Budde @ 2015-10-19 6:34 UTC (permalink / raw)
To: Heiko Schocher, linux-kernel; +Cc: netdev, linux-can, Wolfgang Grandegger
[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]
On 10/19/2015 08:22 AM, Heiko Schocher wrote:
> This patch fixes a warning in clk_enable by calling
> clk_prepare_enable instead.
What about the corresponding clk_disable_unprepare()?
Marc
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>
> drivers/net/can/ti_hecc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
> index cf345cb..c08e8ea 100644
> --- a/drivers/net/can/ti_hecc.c
> +++ b/drivers/net/can/ti_hecc.c
> @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
> netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll,
> HECC_DEF_NAPI_WEIGHT);
>
> - clk_enable(priv->clk);
> + clk_prepare_enable(priv->clk);
> err = register_candev(ndev);
> if (err) {
> dev_err(&pdev->dev, "register_candev() failed\n");
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net, can, ti_hecc: fix a run time warn_on.
2015-10-19 6:34 ` Marc Kleine-Budde
@ 2015-10-19 6:51 ` Heiko Schocher
0 siblings, 0 replies; 3+ messages in thread
From: Heiko Schocher @ 2015-10-19 6:51 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: linux-kernel, netdev, linux-can, Wolfgang Grandegger
Hello Marc,
Am 19.10.2015 um 08:34 schrieb Marc Kleine-Budde:
> On 10/19/2015 08:22 AM, Heiko Schocher wrote:
>> This patch fixes a warning in clk_enable by calling
>> clk_prepare_enable instead.
>
> What about the corresponding clk_disable_unprepare()?
Yes, that should be fixed too, do this in a v2, thanks!
bye,
Heiko
>
> Marc
>
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>>
>> drivers/net/can/ti_hecc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
>> index cf345cb..c08e8ea 100644
>> --- a/drivers/net/can/ti_hecc.c
>> +++ b/drivers/net/can/ti_hecc.c
>> @@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
>> netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll,
>> HECC_DEF_NAPI_WEIGHT);
>>
>> - clk_enable(priv->clk);
>> + clk_prepare_enable(priv->clk);
>> err = register_candev(ndev);
>> if (err) {
>> dev_err(&pdev->dev, "register_candev() failed\n");
>>
>
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-19 6:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-19 6:22 [PATCH] net, can, ti_hecc: fix a run time warn_on Heiko Schocher
2015-10-19 6:34 ` Marc Kleine-Budde
2015-10-19 6:51 ` Heiko Schocher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).