* [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents
@ 2015-10-27 11:16 huangdaode
2015-10-28 3:20 ` David Miller
2015-10-30 14:20 ` Arnd Bergmann
0 siblings, 2 replies; 7+ messages in thread
From: huangdaode @ 2015-10-27 11:16 UTC (permalink / raw)
To: davem, robh+dt
Cc: mark.rutland, devicetree, salil.mehta, kenneth-lee-2012,
pawel.moll, ijc+devicetree, catalin.marinas, lipeng321,
will.deacon, linux-kernel, xuwei5, linuxarm, Yisen.Zhuang,
huangdaode, galak, lisheng011, liguozhu, netdev,
linux-arm-kernel
From: yankejian <yankejian@huawei.com>
updates the bindings documents and dtsi file according to the review
comments[https://lkml.org/lkml/2015/9/21/670] from Rob Herring <robh@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: yankejian <yankejian@huawei.com>
Signed-off-by: huangdaode <huangdaode@hisilicon.com>
---
Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 2 +-
arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
index 9940aa0..9c23fdf 100644
--- a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
+++ b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
@@ -12,7 +12,7 @@ Example:
mdio@803c0000 {
#address-cells = <1>;
#size-cells = <0>;
- compatible = "hisilicon,mdio","hisilicon,hns-mdio";
+ compatible = "hisilicon,hns-mdio","hisilicon,mdio";
reg = <0x0 0x803c0000 0x0 0x10000>;
ethernet-phy@0 {
diff --git a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
index 3500586..606dd5a 100644
--- a/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip05_hns.dtsi
@@ -13,14 +13,12 @@ soc0: soc@000000000 {
reg = <0x0 0x803c0000 0x0 0x10000
0x0 0x80000000 0x0 0x10000>;
- soc0_phy4: ethernet-phy@4 {
+ soc0_phy0: ethernet-phy@0 {
reg = <0x0>;
- device_type = "ethernet-phy";
compatible = "ethernet-phy-ieee802.3-c22";
};
- soc0_phy5: ethernet-phy@5 {
+ soc0_phy1: ethernet-phy@1 {
reg = <0x1>;
- device_type = "ethernet-phy";
compatible = "ethernet-phy-ieee802.3-c22";
};
};
@@ -37,7 +35,7 @@ soc0: soc@000000000 {
0x0 0xc7000000 0x0 0x60000
>;
- phy-handle = <0 0 0 0 &soc0_phy4 &soc0_phy5 0 0>;
+ phy-handle = <0 0 0 0 &soc0_phy0 &soc0_phy1 0 0>;
interrupts = <
/* [14] ge fifo err 8 / xge 6**/
149 0x4 150 0x4 151 0x4 152 0x4
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents
2015-10-27 11:16 [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents huangdaode
@ 2015-10-28 3:20 ` David Miller
2015-10-30 14:20 ` Arnd Bergmann
1 sibling, 0 replies; 7+ messages in thread
From: David Miller @ 2015-10-28 3:20 UTC (permalink / raw)
To: huangdaode
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, devicetree, linux-kernel,
linux-arm-kernel, liguozhu, Yisen.Zhuang, netdev, linuxarm,
salil.mehta, kenneth-lee-2012, xuwei5, lisheng011, lipeng321
From: huangdaode <huangdaode@hisilicon.com>
Date: Tue, 27 Oct 2015 19:16:34 +0800
> From: yankejian <yankejian@huawei.com>
>
> updates the bindings documents and dtsi file according to the review
> comments[https://lkml.org/lkml/2015/9/21/670] from Rob Herring <robh@kernel.org>
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: yankejian <yankejian@huawei.com>
> Signed-off-by: huangdaode <huangdaode@hisilicon.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents
2015-10-27 11:16 [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents huangdaode
2015-10-28 3:20 ` David Miller
@ 2015-10-30 14:20 ` Arnd Bergmann
2015-10-31 1:40 ` huangdaode
1 sibling, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2015-10-30 14:20 UTC (permalink / raw)
To: huangdaode
Cc: davem, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak,
catalin.marinas, will.deacon, devicetree, linux-kernel,
linux-arm-kernel, liguozhu, Yisen.Zhuang, netdev, linuxarm,
salil.mehta, kenneth-lee-2012, xuwei5, lisheng011, lipeng321
On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
> mdio@803c0000 {
> #address-cells = <1>;
> #size-cells = <0>;
> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
> reg = <0x0 0x803c0000 0x0 0x10000>;
>
>
Does "hisilicon,mdio" actually have a specific meaning? Is that just there
for legacy reasons?
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents
2015-10-30 14:20 ` Arnd Bergmann
@ 2015-10-31 1:40 ` huangdaode
[not found] ` <56341C00.8080303-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: huangdaode @ 2015-10-31 1:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, catalin.marinas-5wv7dgnIgG8,
will.deacon-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
liguozhu-C8/M+/jPZTeaMJb+Lgu22Q,
Yisen.Zhuang-hv44wF8Li93QT0dZR+AlfA,
netdev-u79uwXL29TY76Z2rM5mHXA, linuxarm-hv44wF8Li93QT0dZR+AlfA,
salil.mehta-hv44wF8Li93QT0dZR+AlfA,
kenneth-lee-2012-H32Fclmsjq1BDgjK7y7TUQ,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q, lisheng011-hv44wF8Li93QT0dZR+AlfA,
lipeng321-hv44wF8Li93QT0dZR+AlfA
On 2015/10/30 22:20, Arnd Bergmann wrote:
> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
>> mdio@803c0000 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
>> reg = <0x0 0x803c0000 0x0 0x10000>;
>>
>>
> Does "hisilicon,mdio" actually have a specific meaning? Is that just there
> for legacy reasons?
>
> Arnd
>
> .
>
hi Arnd,
"hisilicon,mdio" is the gernerical configuation compatible for the
default hisilicon chip,
We use generic hisilicon since our MDIO/PHY is same across flavour of SoCs.
--
Best Regards
Daode Huang
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents
[not found] ` <56341C00.8080303-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
@ 2015-10-31 2:18 ` Salil Mehta
2015-11-02 22:05 ` Arnd Bergmann
0 siblings, 1 reply; 7+ messages in thread
From: Salil Mehta @ 2015-10-31 2:18 UTC (permalink / raw)
To: huangdaode, Arnd Bergmann
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, catalin.marinas-5wv7dgnIgG8,
will.deacon-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
liguozhu-C8/M+/jPZTeaMJb+Lgu22Q,
Yisen.Zhuang-hv44wF8Li93QT0dZR+AlfA,
netdev-u79uwXL29TY76Z2rM5mHXA, linuxarm-hv44wF8Li93QT0dZR+AlfA,
kenneth-lee-2012-H32Fclmsjq1BDgjK7y7TUQ,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q, lisheng011-hv44wF8Li93QT0dZR+AlfA,
lipeng321-hv44wF8Li93QT0dZR+AlfA
On 10/31/2015 1:40 AM, huangdaode wrote:
> On 2015/10/30 22:20, Arnd Bergmann wrote:
>> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
>>> mdio@803c0000 {
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
>>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
>>> reg = <0x0 0x803c0000 0x0 0x10000>;
>>>
>> Does "hisilicon,mdio" actually have a specific meaning? Is that just
>> there
>> for legacy reasons?
>>
>> Arnd
>>
>> .
>>
> hi Arnd,
> "hisilicon,mdio" is the gernerical configuation compatible for the
> default hisilicon chip,
> We use generic hisilicon since our MDIO/PHY is same across flavour of
> SoCs.
>
Hi Arnd,
Yes, "hisilicon,mdio" exists for the legacy reasons to support older SoC
Hip04.
Best Regards
Salil
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents
2015-10-31 2:18 ` Salil Mehta
@ 2015-11-02 22:05 ` Arnd Bergmann
2015-11-12 2:11 ` huangdaode
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2015-11-02 22:05 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Salil Mehta, huangdaode, mark.rutland, devicetree, Yisen.Zhuang,
kenneth-lee-2012, pawel.moll, ijc+devicetree, catalin.marinas,
lipeng321, will.deacon, linux-kernel, xuwei5, linuxarm, robh+dt,
galak, lisheng011, netdev, liguozhu, davem
On Saturday 31 October 2015 02:18:19 Salil Mehta wrote:
> On 10/31/2015 1:40 AM, huangdaode wrote:
> > On 2015/10/30 22:20, Arnd Bergmann wrote:
> >> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
> >>> mdio@803c0000 {
> >>> #address-cells = <1>;
> >>> #size-cells = <0>;
> >>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
> >>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
> >>> reg = <0x0 0x803c0000 0x0 0x10000>;
> >>>
> >> Does "hisilicon,mdio" actually have a specific meaning? Is that just
> >> there
> >> for legacy reasons?
> >>
> >> Arnd
> >>
> >> .
> >>
> > hi Arnd,
> > "hisilicon,mdio" is the gernerical configuation compatible for the
> > default hisilicon chip,
> > We use generic hisilicon since our MDIO/PHY is same across flavour of
> > SoCs.
> >
> Hi Arnd,
> Yes, "hisilicon,mdio" exists for the legacy reasons to support older SoC
> Hip04.
I see. In that case, that compatible string should probably be mentioned
only as 'optional' in the binding, and not used for devices other than
hip04.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents
2015-11-02 22:05 ` Arnd Bergmann
@ 2015-11-12 2:11 ` huangdaode
0 siblings, 0 replies; 7+ messages in thread
From: huangdaode @ 2015-11-12 2:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Salil Mehta,
mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
Yisen.Zhuang-hv44wF8Li93QT0dZR+AlfA,
kenneth-lee-2012-H32Fclmsjq1BDgjK7y7TUQ, pawel.moll-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
catalin.marinas-5wv7dgnIgG8, lipeng321-hv44wF8Li93QT0dZR+AlfA,
will.deacon-5wv7dgnIgG8, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q, linuxarm-hv44wF8Li93QT0dZR+AlfA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, galak-sgV2jX0FEOL9JmXXK+q4OQ,
lisheng011-hv44wF8Li93QT0dZR+AlfA, netdev-u79uwXL29TY76Z2rM5mHXA,
liguozhu-C8/M+/jPZTeaMJb+Lgu22Q, davem-fT/PcQaiUtIeIZ0/mPfg9Q
On 2015/11/3 6:05, Arnd Bergmann wrote:
> On Saturday 31 October 2015 02:18:19 Salil Mehta wrote:
>> On 10/31/2015 1:40 AM, huangdaode wrote:
>>> On 2015/10/30 22:20, Arnd Bergmann wrote:
>>>> On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
>>>>> mdio@803c0000 {
>>>>> #address-cells = <1>;
>>>>> #size-cells = <0>;
>>>>> - compatible = "hisilicon,mdio","hisilicon,hns-mdio";
>>>>> + compatible = "hisilicon,hns-mdio","hisilicon,mdio";
>>>>> reg = <0x0 0x803c0000 0x0 0x10000>;
>>>>>
>>>> Does "hisilicon,mdio" actually have a specific meaning? Is that just
>>>> there
>>>> for legacy reasons?
>>>>
>>>> Arnd
>>>>
>>>> .
>>>>
>>> hi Arnd,
>>> "hisilicon,mdio" is the gernerical configuation compatible for the
>>> default hisilicon chip,
>>> We use generic hisilicon since our MDIO/PHY is same across flavour of
>>> SoCs.
>>>
>> Hi Arnd,
>> Yes, "hisilicon,mdio" exists for the legacy reasons to support older SoC
>> Hip04.
> I see. In that case, that compatible string should probably be mentioned
> only as 'optional' in the binding, and not used for devices other than
> hip04.
>
> Arnd
>
> .
>
Hi, Arnd
ok, ill send a patch to specify it, please Ack then.
thanks
Daode.
--
Best Regards
Daode Huang
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-12 2:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-27 11:16 [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents huangdaode
2015-10-28 3:20 ` David Miller
2015-10-30 14:20 ` Arnd Bergmann
2015-10-31 1:40 ` huangdaode
[not found] ` <56341C00.8080303-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2015-10-31 2:18 ` Salil Mehta
2015-11-02 22:05 ` Arnd Bergmann
2015-11-12 2:11 ` huangdaode
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).