netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bpf: fix trivial comment typo
@ 2015-11-02  0:59 Matthew Fernandez
  2015-11-02 21:31 ` David Miller
  0 siblings, 1 reply; 5+ messages in thread
From: Matthew Fernandez @ 2015-11-02  0:59 UTC (permalink / raw)
  To: netdev; +Cc: trivial, ast, linux-kernel

bpf: fix trivial comment typo

Signed-off-by: Matthew Fernandez <matthew.fernandez@gmail.com>

diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
index 67c380c..996db5c 100644
--- a/kernel/bpf/core.c
+++ b/kernel/bpf/core.c
@@ -456,7 +456,7 @@ select_insn:

  		/* ARG1 at this point is guaranteed to point to CTX from
  		 * the verifier side due to the fact that the tail call is
-		 * handeled like a helper, that is, bpf_tail_call_proto,
+		 * handled like a helper, that is, bpf_tail_call_proto,
  		 * where arg1_type is ARG_PTR_TO_CTX.
  		 */
  		insn = prog->insnsi;

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] bpf: fix trivial comment typo
  2015-11-02  0:59 [PATCH] bpf: fix trivial comment typo Matthew Fernandez
@ 2015-11-02 21:31 ` David Miller
  2015-11-02 21:48   ` Matthew Fernandez
  0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2015-11-02 21:31 UTC (permalink / raw)
  To: matthew.fernandez; +Cc: netdev, trivial, ast, linux-kernel

From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Mon, 2 Nov 2015 11:59:03 +1100

> bpf: fix trivial comment typo
> 
> Signed-off-by: Matthew Fernandez <matthew.fernandez@gmail.com>

This doesn't apply to any tree.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] bpf: fix trivial comment typo
  2015-11-02 21:31 ` David Miller
@ 2015-11-02 21:48   ` Matthew Fernandez
  2015-11-03  9:48     ` Daniel Borkmann
  0 siblings, 1 reply; 5+ messages in thread
From: Matthew Fernandez @ 2015-11-02 21:48 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, trivial, ast, linux-kernel

On 03/11/15 08:31, David Miller wrote:
> From: Matthew Fernandez <matthew.fernandez@gmail.com>
> Date: Mon, 2 Nov 2015 11:59:03 +1100
>
>> bpf: fix trivial comment typo
>>
>> Signed-off-by: Matthew Fernandez <matthew.fernandez@gmail.com>
>
> This doesn't apply to any tree.

I'm sorry, I think I must be missing something. This seems to apply cleanly to the current tip of mainline 
(e86328c489d7) to me. Was this not in the expected format? It wasn't my intention to waste your time, so I apologise for 
any newbie errors.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] bpf: fix trivial comment typo
  2015-11-02 21:48   ` Matthew Fernandez
@ 2015-11-03  9:48     ` Daniel Borkmann
  2015-11-05  0:05       ` Matthew Fernandez
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Borkmann @ 2015-11-03  9:48 UTC (permalink / raw)
  To: Matthew Fernandez, David Miller; +Cc: netdev, trivial, ast, linux-kernel

On 11/02/2015 10:48 PM, Matthew Fernandez wrote:
> On 03/11/15 08:31, David Miller wrote:
>> From: Matthew Fernandez <matthew.fernandez@gmail.com>
>> Date: Mon, 2 Nov 2015 11:59:03 +1100
>>
>>> bpf: fix trivial comment typo
>>>
>>> Signed-off-by: Matthew Fernandez <matthew.fernandez@gmail.com>
>>
>> This doesn't apply to any tree.
>
> I'm sorry, I think I must be missing something. This seems to apply cleanly to the current tip of mainline (e86328c489d7) to me. Was this not in the expected format? It wasn't my intention to waste your time, so I apologise for any newbie errors.

You might want to check Documentation/networking/netdev-FAQ.txt ;),
and rebase your spelling fix f.e. to the latest net-next tree.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] bpf: fix trivial comment typo
  2015-11-03  9:48     ` Daniel Borkmann
@ 2015-11-05  0:05       ` Matthew Fernandez
  0 siblings, 0 replies; 5+ messages in thread
From: Matthew Fernandez @ 2015-11-05  0:05 UTC (permalink / raw)
  To: Daniel Borkmann, David Miller; +Cc: netdev, trivial, ast, linux-kernel

On 03/11/15 20:48, Daniel Borkmann wrote:
> On 11/02/2015 10:48 PM, Matthew Fernandez wrote:
>> On 03/11/15 08:31, David Miller wrote:
>>> From: Matthew Fernandez <matthew.fernandez@gmail.com>
>>> Date: Mon, 2 Nov 2015 11:59:03 +1100
>>>
>>>> bpf: fix trivial comment typo
>>>>
>>>> Signed-off-by: Matthew Fernandez <matthew.fernandez@gmail.com>
>>>
>>> This doesn't apply to any tree.
>>
>> I'm sorry, I think I must be missing something. This seems to apply cleanly to the current tip of
>> mainline (e86328c489d7) to me. Was this not in the expected format? It wasn't my intention to
>> waste your time, so I apologise for any newbie errors.
>
> You might want to check Documentation/networking/netdev-FAQ.txt ;),
> and rebase your spelling fix f.e. to the latest net-next tree.

Ah right, sorry about that. Thanks for the info, Daniel. From netdev-FAQ it sounds like this patch 
would be more appropriate for the net tree, but as the target file is identical in both right now 
I'll leave it to someone else's discretion to decide which is more suitable. Will rebase and resubmit.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-11-05  0:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-02  0:59 [PATCH] bpf: fix trivial comment typo Matthew Fernandez
2015-11-02 21:31 ` David Miller
2015-11-02 21:48   ` Matthew Fernandez
2015-11-03  9:48     ` Daniel Borkmann
2015-11-05  0:05       ` Matthew Fernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).