From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Janne Grunau" <j@jannau.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Mailing List" <devicetree-spec@vger.kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"van Spriel" <arend@broadcom.com>,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] dt-bindings: net: Add network-class schema for mac-address properties
Date: Fri, 3 Feb 2023 22:08:38 +0100 [thread overview]
Message-ID: <5651774d-3f60-ebb1-0613-83917d8c4bd9@linaro.org> (raw)
In-Reply-To: <20230203-dt-bindings-network-class-v1-1-452e0375200d@jannau.net>
On 03/02/2023 14:56, Janne Grunau wrote:
> The ethernet-controller schema specifies "mac-address" and
> "local-mac-address" but other network devices such as wireless network
> adapters use mac addresses as well.
> The Devicetree Specification, Release v0.3 specifies in section 4.3.1
> a generic "Network Class Binding" with "address-bits", "mac-address",
> "local-mac-address" and "max-frame-size". This schema specifies the
> "address-bits" property and moves "local-mac-address" and "mac-address"
> over from ethernet-controller.yaml.
> The schema currently does not restrict MAC address size based on
> address-bits.
A nit below
> phy-mode:
> diff --git a/Documentation/devicetree/bindings/net/network-class.yaml b/Documentation/devicetree/bindings/net/network-class.yaml
> new file mode 100644
> index 000000000000..676aec1c458e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/network-class.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/network-class.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Network Class Bindings
s/Bindings/Common Properties/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-03 21:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:56 [PATCH RFC 0/3] dt-bindings: net: Add network-class.yaml schema Janne Grunau
2023-02-03 13:56 ` [PATCH RFC 1/3] dt-bindings: net: Add network-class schema for mac-address properties Janne Grunau
2023-02-03 14:25 ` Rob Herring
2023-02-03 21:08 ` Krzysztof Kozlowski [this message]
2023-02-03 13:56 ` [PATCH RFC 2/3] dt-bindings: wireless: bcm4329-fmac: Use network-class.yaml schema Janne Grunau
2023-02-03 13:56 ` [PATCH RFC 3/3] dt-bindings: wireless: silabs,wfx: Use network-class.yaml Janne Grunau
2023-02-03 14:41 ` [PATCH RFC 0/3] dt-bindings: net: Add network-class.yaml schema Rob Herring
2023-02-06 16:31 ` Janne Grunau
2023-02-07 1:34 ` Andrew Lunn
2023-02-07 7:10 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5651774d-3f60-ebb1-0613-83917d8c4bd9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arend@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree-spec@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=j@jannau.net \
--cc=jerome.pouiller@silabs.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).