From: Andrew Lunn <andrew@lunn.ch>
To: Janne Grunau <j@jannau.net>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Mailing List" <devicetree-spec@vger.kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"van Spriel" <arend@broadcom.com>,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH RFC 0/3] dt-bindings: net: Add network-class.yaml schema
Date: Tue, 7 Feb 2023 02:34:41 +0100 [thread overview]
Message-ID: <Y+GqsTLXRKyg0BdV@lunn.ch> (raw)
In-Reply-To: <20230206163154.GA9004@jannau.net>
> > > I've ignored "max-frame-size" since the description in
> > > ethernet-controller.yaml claims there is a contradiction in the
> > > Devicetree specification. I suppose it is describing the property
> > > "max-frame-size" with "Specifies maximum packet length ...".
> >
> > Please include it and we'll fix the spec. It is clearly wrong. 2 nios
> > boards use 1518 and the consumer for them says it is MTU. Everything
> > else clearly uses mtu with 1500 or 9000.
>
> Ok, the example in the pdf is 'max-frame-size = <1518>;'. I'll include
> it with the description of ethernet-controller.yaml which specifies it
> as MTU.
You need to be careful here. Frame and MTU are different things.
The IEEE 802.3 standard says nothing about MTU. I believe MTU is an IP
concept. It is the size of the SDU an Ethernet PDU can carry. This is
typically 1500.
Historically, the max Ethernet frame size was 1518. But with 802.1Q
which added the VLAN header, all modern hardware actual uses 1522 to
accommodate the extra 4 bytes VLAN header. So i would not actually put
max-frame-size = <1518> anywhere, because it will get copy/pasted and
break VLAN setups.
It looks like the ibm,emac.txt makes this error, max-frame-size =
<5dc>; 0x5dc is 1500. And there are a few powerpc .dtc using
1500/0x5dc, which are probably broken.
Andrew
next prev parent reply other threads:[~2023-02-07 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:56 [PATCH RFC 0/3] dt-bindings: net: Add network-class.yaml schema Janne Grunau
2023-02-03 13:56 ` [PATCH RFC 1/3] dt-bindings: net: Add network-class schema for mac-address properties Janne Grunau
2023-02-03 14:25 ` Rob Herring
2023-02-03 21:08 ` Krzysztof Kozlowski
2023-02-03 13:56 ` [PATCH RFC 2/3] dt-bindings: wireless: bcm4329-fmac: Use network-class.yaml schema Janne Grunau
2023-02-03 13:56 ` [PATCH RFC 3/3] dt-bindings: wireless: silabs,wfx: Use network-class.yaml Janne Grunau
2023-02-03 14:41 ` [PATCH RFC 0/3] dt-bindings: net: Add network-class.yaml schema Rob Herring
2023-02-06 16:31 ` Janne Grunau
2023-02-07 1:34 ` Andrew Lunn [this message]
2023-02-07 7:10 ` Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+GqsTLXRKyg0BdV@lunn.ch \
--to=andrew@lunn.ch \
--cc=arend@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree-spec@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=j@jannau.net \
--cc=jerome.pouiller@silabs.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).