From: Roi Dayan <roid@nvidia.com>
To: David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: <netdev@vger.kernel.org>, Paul Blakey <paulb@nvidia.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH iproute2-next v4 1/1] police: Add support for json output
Date: Tue, 6 Jul 2021 11:30:31 +0300 [thread overview]
Message-ID: <5918cbc9-9569-15fb-6ee6-fea13a7cca2d@nvidia.com> (raw)
In-Reply-To: <3678ebef-39b3-7e00-1ad1-114889aba683@gmail.com>
On 2021-07-05 7:30 PM, David Ahern wrote:
> On 7/5/21 10:28 AM, Stephen Hemminger wrote:
>> On Mon, 7 Jun 2021 09:44:08 +0300
>> Roi Dayan <roid@nvidia.com> wrote:
>>
>>> - fprintf(f, " police 0x%x ", p->index);
>>> + print_uint(PRINT_ANY, "index", "\t index %u ", p->index);
>>
>> Why did output format have to change here? Why not:
>>
>> print_hex(PRINT_ANY, "police", " police %#x", p->index);
>>
>
> it should not have. I caught it in the first version in a review
> comment; missed it in v4 that was applied.
>
Hi,
I replied to your review in v0 that I wanted to match all the other
actions output which output as unsigned.
Since I didn't get another reply I thought its ok to continue and sent
another version which other changes that were required.
next prev parent reply other threads:[~2021-07-06 8:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 6:44 [PATCH iproute2-next v4 1/1] police: Add support for json output Roi Dayan
2021-06-11 2:35 ` David Ahern
2021-07-05 10:41 ` Hangbin Liu
2021-07-06 8:27 ` Davide Caratti
2021-07-07 6:53 ` Hangbin Liu
2021-07-08 6:57 ` Roi Dayan
2021-07-08 7:23 ` Roi Dayan
2021-07-08 14:46 ` David Ahern
2021-07-11 10:24 ` Roi Dayan
2021-07-11 16:00 ` David Ahern
2021-07-12 11:02 ` Jamal Hadi Salim
2021-07-12 12:28 ` Roi Dayan
2021-07-05 16:28 ` Stephen Hemminger
2021-07-05 16:30 ` David Ahern
2021-07-06 8:30 ` Roi Dayan [this message]
2021-07-06 8:36 ` Roi Dayan
2021-07-05 16:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5918cbc9-9569-15fb-6ee6-fea13a7cca2d@nvidia.com \
--to=roid@nvidia.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).