From: David Ahern <dsahern@gmail.com>
To: Roi Dayan <roid@nvidia.com>, Hangbin Liu <liuhangbin@gmail.com>,
Davide Caratti <dcaratti@redhat.com>
Cc: netdev@vger.kernel.org, Paul Blakey <paulb@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Roman Mashak <mrv@mojatatu.com>,
Baowen Zheng <baowen.zheng@corigine.com>
Subject: Re: [PATCH iproute2-next v4 1/1] police: Add support for json output
Date: Sun, 11 Jul 2021 10:00:41 -0600 [thread overview]
Message-ID: <db692da0-680f-a6a9-138b-752e262bf899@gmail.com> (raw)
In-Reply-To: <37a0aae7-d32b-4dfd-9832-5b443d73abb6@nvidia.com>
On 7/11/21 4:24 AM, Roi Dayan wrote:
>
>
> On 2021-07-08 5:46 PM, David Ahern wrote:
>> On 7/8/21 12:57 AM, Roi Dayan wrote:
>>>
>>>
>>> On 2021-07-07 9:53 AM, Hangbin Liu wrote:
>>>> On Tue, Jul 06, 2021 at 10:27:34AM +0200, Davide Caratti wrote:
>>>>> my 2 cents:
>>>>>
>>>>> what about using PRINT_FP / PRINT_JSON, so we fix the JSON output
>>>>> only to show "index", and
>>>>> preserve the human-readable printout iproute and kselftests? besides
>>>>> avoiding failures because
>>>>> of mismatching kselftests / iproute, this would preserve
>>>>> functionality of scripts that
>>>>> configure / dump the "police" action. WDYT?
>>>>
>>>> +1
>>>>
>>>
>>>
>>> why not fix the kselftest to look for the correct output?
>>
>> That is but 1 user. The general rule is that you do not change the
>> output like you did.
>>
>
> but the output was "broken" and not consistent with all actions.
> we are not fixing this kind of thing?
It has been in hex since 2004, and you can not decide in 2021 that it is
'broken' and change it.
> so to continue with the suggestion to use print_fp and keep police
> action output broken and print_json for the json output?
> just to be sure before submitting change back to old output for fp.
>
>
> ...
> action order 1: police 0x1 rate 1Mbit burst 20Kb mtu 2Kb action
> reclassify overhead 0b
>
>
>
>
> - print_string(PRINT_ANY, "kind", "%s", "police");
> + print_string(PRINT_JSON, "kind", "%s", "police");
>
> - print_uint(PRINT_ANY, "index", "\tindex %u ", p->index);
> + print_hex(PRINT_FP, NULL, " police 0x%x ", p->index);
> + print_uint(PRINT_JSON, "index", NULL, p->index);
>
>
Jamal: opinions?
next prev parent reply other threads:[~2021-07-11 16:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 6:44 [PATCH iproute2-next v4 1/1] police: Add support for json output Roi Dayan
2021-06-11 2:35 ` David Ahern
2021-07-05 10:41 ` Hangbin Liu
2021-07-06 8:27 ` Davide Caratti
2021-07-07 6:53 ` Hangbin Liu
2021-07-08 6:57 ` Roi Dayan
2021-07-08 7:23 ` Roi Dayan
2021-07-08 14:46 ` David Ahern
2021-07-11 10:24 ` Roi Dayan
2021-07-11 16:00 ` David Ahern [this message]
2021-07-12 11:02 ` Jamal Hadi Salim
2021-07-12 12:28 ` Roi Dayan
2021-07-05 16:28 ` Stephen Hemminger
2021-07-05 16:30 ` David Ahern
2021-07-06 8:30 ` Roi Dayan
2021-07-06 8:36 ` Roi Dayan
2021-07-05 16:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db692da0-680f-a6a9-138b-752e262bf899@gmail.com \
--to=dsahern@gmail.com \
--cc=baowen.zheng@corigine.com \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=liuhangbin@gmail.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=roid@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).