* [PATCH -next] net: ice: Fix pointer cast warnings
@ 2020-07-31 10:57 Bixuan Cui
2020-07-31 10:07 ` [PATCH -next v2] " Bixuan Cui
0 siblings, 1 reply; 5+ messages in thread
From: Bixuan Cui @ 2020-07-31 10:57 UTC (permalink / raw)
To: davem, kuba; +Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-next
pointers should be casted to unsigned long to avoid
-Wpointer-to-int-cast warnings:
drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning:
cast from pointer to integer of different size
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/net/ethernet/intel/ice/ice_flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 3913da2116d2..b9a5c208e484 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -194,7 +194,7 @@ struct ice_flow_entry {
u16 entry_sz;
};
-#define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
+#define ICE_FLOW_ENTRY_HNDL(e) ((uintptr_t)e)
#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
struct ice_flow_prof {
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH -next v2] net: ice: Fix pointer cast warnings
2020-07-31 10:57 [PATCH -next] net: ice: Fix pointer cast warnings Bixuan Cui
@ 2020-07-31 10:07 ` Bixuan Cui
2020-08-26 23:22 ` Brown, Aaron F
2020-09-23 1:44 ` [PATCH -next v2] " Bixuan Cui
0 siblings, 2 replies; 5+ messages in thread
From: Bixuan Cui @ 2020-07-31 10:07 UTC (permalink / raw)
To: davem, kuba; +Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-next
pointers should be casted to unsigned long to avoid
-Wpointer-to-int-cast warnings:
drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning:
cast from pointer to integer of different size
drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning:
cast to pointer from integer of different size
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
v2->v1: add fix:
ice_flow.h:198:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 3913da2116d2..829f90b1e998 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -194,8 +194,8 @@ struct ice_flow_entry {
u16 entry_sz;
};
-#define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
-#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
+#define ICE_FLOW_ENTRY_HNDL(e) ((u64)(uintptr_t)e)
+#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(uintptr_t)(h))
struct ice_flow_prof {
struct list_head l_entry;
--
2.17.1
.
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH -next v2] net: ice: Fix pointer cast warnings
2020-07-31 10:07 ` [PATCH -next v2] " Bixuan Cui
@ 2020-08-26 23:22 ` Brown, Aaron F
2020-09-23 1:58 ` [PATCH v3] " Bixuan Cui
2020-09-23 1:44 ` [PATCH -next v2] " Bixuan Cui
1 sibling, 1 reply; 5+ messages in thread
From: Brown, Aaron F @ 2020-08-26 23:22 UTC (permalink / raw)
To: Bixuan Cui, davem, kuba
Cc: Kirsher, Jeffrey T, intel-wired-lan, netdev, linux-next
> From: Bixuan Cui <cuibixuan@huawei.com>
> Sent: Friday, July 31, 2020 3:08 AM
> To: davem@davemloft.net; kuba@kernel.org
> Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired-
> lan@lists.osuosl.org; netdev@vger.kernel.org; linux-next@vger.kernel.org
> Subject: [PATCH -next v2] net: ice: Fix pointer cast warnings
>
> pointers should be casted to unsigned long to avoid
> -Wpointer-to-int-cast warnings:
>
> drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning:
> cast from pointer to integer of different size
> drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning:
> cast to pointer from integer of different size
>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> v2->v1: add fix:
> ice_flow.h:198:32: warning: cast to pointer from integer of different size [-
> Wint-to-pointer-cast]
> #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
>
> drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] net: ice: Fix pointer cast warnings
2020-08-26 23:22 ` Brown, Aaron F
@ 2020-09-23 1:58 ` Bixuan Cui
0 siblings, 0 replies; 5+ messages in thread
From: Bixuan Cui @ 2020-09-23 1:58 UTC (permalink / raw)
To: Brown, Aaron F, davem, kuba
Cc: Kirsher, Jeffrey T, intel-wired-lan, netdev, linux-next
pointers should be casted to unsigned long to avoid
-Wpointer-to-int-cast warnings:
drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning:
cast from pointer to integer of different size
drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning:
cast to pointer from integer of different size
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
---
v3->v2: add 'Tested-by: Aaron Brown <aaron.f.brown@intel.com>'
v2->v1: add fix:
ice_flow.h:198:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
index 3913da2116d2..829f90b1e998 100644
--- a/drivers/net/ethernet/intel/ice/ice_flow.h
+++ b/drivers/net/ethernet/intel/ice/ice_flow.h
@@ -194,8 +194,8 @@ struct ice_flow_entry {
u16 entry_sz;
};
-#define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
-#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
+#define ICE_FLOW_ENTRY_HNDL(e) ((u64)(uintptr_t)e)
+#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(uintptr_t)(h))
struct ice_flow_prof {
struct list_head l_entry;
--
2.17.1
.
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next v2] net: ice: Fix pointer cast warnings
2020-07-31 10:07 ` [PATCH -next v2] " Bixuan Cui
2020-08-26 23:22 ` Brown, Aaron F
@ 2020-09-23 1:44 ` Bixuan Cui
1 sibling, 0 replies; 5+ messages in thread
From: Bixuan Cui @ 2020-09-23 1:44 UTC (permalink / raw)
To: davem, kuba; +Cc: jeffrey.t.kirsher, intel-wired-lan, netdev, linux-next
ping~
On 2020/7/31 18:07, Bixuan Cui wrote:
> pointers should be casted to unsigned long to avoid
> -Wpointer-to-int-cast warnings:
>
> drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning:
> cast from pointer to integer of different size
> drivers/net/ethernet/intel/ice/ice_flow.h:198:32: warning:
> cast to pointer from integer of different size
>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> ---
> v2->v1: add fix:
> ice_flow.h:198:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
>
> drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_flow.h b/drivers/net/ethernet/intel/ice/ice_flow.h
> index 3913da2116d2..829f90b1e998 100644
> --- a/drivers/net/ethernet/intel/ice/ice_flow.h
> +++ b/drivers/net/ethernet/intel/ice/ice_flow.h
> @@ -194,8 +194,8 @@ struct ice_flow_entry {
> u16 entry_sz;
> };
>
> -#define ICE_FLOW_ENTRY_HNDL(e) ((u64)e)
> -#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h))
> +#define ICE_FLOW_ENTRY_HNDL(e) ((u64)(uintptr_t)e)
> +#define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(uintptr_t)(h))
>
> struct ice_flow_prof {
> struct list_head l_entry;
> --
> 2.17.1
>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-23 1:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31 10:57 [PATCH -next] net: ice: Fix pointer cast warnings Bixuan Cui
2020-07-31 10:07 ` [PATCH -next v2] " Bixuan Cui
2020-08-26 23:22 ` Brown, Aaron F
2020-09-23 1:58 ` [PATCH v3] " Bixuan Cui
2020-09-23 1:44 ` [PATCH -next v2] " Bixuan Cui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).