From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Vlad Buslov <vlad@buslov.dev>
Cc: David Ahern <dsahern@gmail.com>, Vlad Buslov <vladbu@nvidia.com>,
stephen@networkplumber.org, xiyou.wangcong@gmail.com,
netdev@vger.kernel.org, davem@davemloft.net, jiri@resnulli.us,
ivecera@redhat.com, Vlad Buslov <vladbu@mellanox.com>
Subject: Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump
Date: Fri, 9 Oct 2020 08:45:21 -0400 [thread overview]
Message-ID: <5d4231c5-94d2-4d14-292f-e68d015ea260@mojatatu.com> (raw)
In-Reply-To: <87ft6n1tp8.fsf@buslov.dev>
On 2020-10-09 8:15 a.m., Vlad Buslov wrote:
>
> On Fri 09 Oct 2020 at 15:03, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>> Which test(s)?
>> I see for example d45e mentioning terse but i dont see corresponding
>> code in the iproute2 tree i just pulled.
>
> Yes. The tests d45e and 7c65 were added as a part of kernel series, but
> corresponding iproute2 patches were never merged. Tests expect original
> "terse flag" syntax of V1 iproute2 series and will have to be changed to
> use -brief option instead.
Then i dont see a problem in changing the tests.
If you are going to send a v3 please include my acked-by.
Would have been nice to see what terse output would have looked like.
cheers,
jamal
next prev parent reply other threads:[~2020-10-09 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 16:59 [PATCH iproute2-next v2 0/2] Implement filter terse dump mode support Vlad Buslov
2020-09-30 16:59 ` [PATCH iproute2-next v2 1/2] tc: skip actions that don't have options attribute when printing Vlad Buslov
2020-09-30 16:59 ` [PATCH iproute2-next v2 2/2] tc: implement support for terse dump Vlad Buslov
2020-10-08 1:40 ` David Ahern
2020-10-08 12:58 ` Jamal Hadi Salim
2020-10-08 15:34 ` Vlad Buslov
2020-10-09 12:03 ` Jamal Hadi Salim
2020-10-09 12:15 ` Vlad Buslov
2020-10-09 12:45 ` Jamal Hadi Salim [this message]
2020-10-09 16:38 ` Vlad Buslov
2020-10-13 2:05 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4231c5-94d2-4d14-292f-e68d015ea260@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vlad@buslov.dev \
--cc=vladbu@mellanox.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).