netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <jhs@mojatatu.com>
To: David Ahern <dsahern@gmail.com>, Vlad Buslov <vladbu@nvidia.com>,
	stephen@networkplumber.org, xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@resnulli.us,
	ivecera@redhat.com, Vlad Buslov <vladbu@mellanox.com>
Subject: Re: [PATCH iproute2-next v2 2/2] tc: implement support for terse dump
Date: Thu, 8 Oct 2020 08:58:07 -0400	[thread overview]
Message-ID: <ff969d59-53e0-aca3-2de8-9be41d6d7804@mojatatu.com> (raw)
In-Reply-To: <9961ad12-dc8f-55fc-3f9d-8e1aaca82327@gmail.com>

On 2020-10-07 9:40 p.m., David Ahern wrote:
> On 9/30/20 9:59 AM, Vlad Buslov wrote:
>> From: Vlad Buslov <vladbu@mellanox.com>
>>
>> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
>> tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
>> user requested it with following example CLI (-br for 'brief'):
>>
>>> tc -s -br filter show dev ens1f0 ingress
>>
>> In terse mode dump only outputs essential data needed to identify the
>> filter and action (handle, cookie, etc.) and stats, if requested by the
>> user. The intention is to significantly improve rule dump rate by omitting
>> all static data that do not change after rule is created.
>>
> 
> I really want to get agreement from other heavy tc users about what the
> right information is for a brief mode.

Vlad, would have been helpful in your commit log to show both
terse vs no terse (or at least the terse output). Cant tell short
of patching and testing. Having said that:
The differentiation via TCA_DUMP_FLAGS_TERSE in the request
is in my opinion sufficient to accept the patch.
Also, assuming you have tested with outstanding tc tests for the
first patch i think it looks reasoan

cheers,
jamal

  reply	other threads:[~2020-10-08 12:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 16:59 [PATCH iproute2-next v2 0/2] Implement filter terse dump mode support Vlad Buslov
2020-09-30 16:59 ` [PATCH iproute2-next v2 1/2] tc: skip actions that don't have options attribute when printing Vlad Buslov
2020-09-30 16:59 ` [PATCH iproute2-next v2 2/2] tc: implement support for terse dump Vlad Buslov
2020-10-08  1:40   ` David Ahern
2020-10-08 12:58     ` Jamal Hadi Salim [this message]
2020-10-08 15:34       ` Vlad Buslov
2020-10-09 12:03         ` Jamal Hadi Salim
2020-10-09 12:15           ` Vlad Buslov
2020-10-09 12:45             ` Jamal Hadi Salim
2020-10-09 16:38               ` Vlad Buslov
2020-10-13  2:05                 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff969d59-53e0-aca3-2de8-9be41d6d7804@mojatatu.com \
    --to=jhs@mojatatu.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vladbu@mellanox.com \
    --cc=vladbu@nvidia.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).