* [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS [not found] <20200117165330.17015-1-daniel.diaz@linaro.org> @ 2020-01-17 16:53 ` Daniel Díaz 2020-01-17 19:04 ` Andrii Nakryiko 2020-01-22 17:23 ` Daniel Borkmann 0 siblings, 2 replies; 4+ messages in thread From: Daniel Díaz @ 2020-01-17 16:53 UTC (permalink / raw) To: shuah Cc: Daniel Díaz, Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko, open list:KERNEL SELFTEST FRAMEWORK, open list:BPF (Safe dynamic programs and tools), open list:BPF (Safe dynamic programs and tools), open list During cross-compilation, it was discovered that LDFLAGS and LDLIBS were not being used while building binaries, leading to defaults which were not necessarily correct. OpenEmbedded reported this kind of problem: ERROR: QA Issue: No GNU_HASH in the ELF binary [...], didn't pass LDFLAGS? Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> --- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index e2fd6f8d579c..f1740113d5dc 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -88,7 +88,7 @@ $(notdir $(TEST_GEN_PROGS) \ $(TEST_CUSTOM_PROGS)): %: $(OUTPUT)/% ; $(OUTPUT)/urandom_read: urandom_read.c - $(CC) -o $@ $< -Wl,--build-id + $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) -Wl,--build-id $(OUTPUT)/test_stub.o: test_stub.c $(CC) -c $(CFLAGS) -o $@ $< -- 2.20.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS 2020-01-17 16:53 ` [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS Daniel Díaz @ 2020-01-17 19:04 ` Andrii Nakryiko 2020-01-20 5:06 ` John Fastabend 2020-01-22 17:23 ` Daniel Borkmann 1 sibling, 1 reply; 4+ messages in thread From: Andrii Nakryiko @ 2020-01-17 19:04 UTC (permalink / raw) To: Daniel Díaz Cc: Shuah Khan, Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko, open list:KERNEL SELFTEST FRAMEWORK, open list:BPF (Safe dynamic programs and tools), open list:BPF (Safe dynamic programs and tools), open list On Fri, Jan 17, 2020 at 8:55 AM Daniel Díaz <daniel.diaz@linaro.org> wrote: > > During cross-compilation, it was discovered that LDFLAGS and > LDLIBS were not being used while building binaries, leading > to defaults which were not necessarily correct. > > OpenEmbedded reported this kind of problem: > ERROR: QA Issue: No GNU_HASH in the ELF binary [...], didn't pass LDFLAGS? > > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> > --- Acked-by: Andrii Nakryiko <andriin@fb.com> > tools/testing/selftests/bpf/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > index e2fd6f8d579c..f1740113d5dc 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -88,7 +88,7 @@ $(notdir $(TEST_GEN_PROGS) \ > $(TEST_CUSTOM_PROGS)): %: $(OUTPUT)/% ; > > $(OUTPUT)/urandom_read: urandom_read.c > - $(CC) -o $@ $< -Wl,--build-id > + $(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) -Wl,--build-id > > $(OUTPUT)/test_stub.o: test_stub.c > $(CC) -c $(CFLAGS) -o $@ $< > -- > 2.20.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS 2020-01-17 19:04 ` Andrii Nakryiko @ 2020-01-20 5:06 ` John Fastabend 0 siblings, 0 replies; 4+ messages in thread From: John Fastabend @ 2020-01-20 5:06 UTC (permalink / raw) To: Andrii Nakryiko, Daniel Díaz Cc: Shuah Khan, Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko, open list:KERNEL SELFTEST FRAMEWORK, open list:BPF (Safe dynamic programs and tools), open list:BPF (Safe dynamic programs and tools), open list Andrii Nakryiko wrote: > On Fri, Jan 17, 2020 at 8:55 AM Daniel Díaz <daniel.diaz@linaro.org> wrote: > > > > During cross-compilation, it was discovered that LDFLAGS and > > LDLIBS were not being used while building binaries, leading > > to defaults which were not necessarily correct. > > > > OpenEmbedded reported this kind of problem: > > ERROR: QA Issue: No GNU_HASH in the ELF binary [...], didn't pass LDFLAGS? > > > > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> > > --- > > Acked-by: Andrii Nakryiko <andriin@fb.com> Acked-by: John Fastabend <john.fastabend@gmail.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS 2020-01-17 16:53 ` [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS Daniel Díaz 2020-01-17 19:04 ` Andrii Nakryiko @ 2020-01-22 17:23 ` Daniel Borkmann 1 sibling, 0 replies; 4+ messages in thread From: Daniel Borkmann @ 2020-01-22 17:23 UTC (permalink / raw) To: Daniel Díaz, shuah Cc: Alexei Starovoitov, Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko, open list:KERNEL SELFTEST FRAMEWORK, open list:BPF (Safe dynamic programs and tools), open list:BPF (Safe dynamic programs and tools), open list On 1/17/20 5:53 PM, Daniel Díaz wrote: > During cross-compilation, it was discovered that LDFLAGS and > LDLIBS were not being used while building binaries, leading > to defaults which were not necessarily correct. > > OpenEmbedded reported this kind of problem: > ERROR: QA Issue: No GNU_HASH in the ELF binary [...], didn't pass LDFLAGS? > > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org> Applied, thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-22 17:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200117165330.17015-1-daniel.diaz@linaro.org>
2020-01-17 16:53 ` [PATCH 3/3] selftests/bpf: Build urandom_read with LDFLAGS and LDLIBS Daniel Díaz
2020-01-17 19:04 ` Andrii Nakryiko
2020-01-20 5:06 ` John Fastabend
2020-01-22 17:23 ` Daniel Borkmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).