From: Christian Melki <christian.melki@t2data.com>
To: netdev@vger.kernel.org
Subject: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081
Date: Thu, 18 Feb 2021 22:09:32 +0100 [thread overview]
Message-ID: <5eb8b25e-f646-ed3d-8572-9b6ef318ae9e@t2data.com> (raw)
Following a similar reinstate for the KSZ9031.
Older kernels would use the genphy_soft_reset if the PHY did not
implement a .soft_reset.
Bluntly removing that default may expose a lot of situations where
various PHYs/board implementations won't recover on various changes.
Like with implementation during a 4.9.x to 5.4.x LTS transition.
I think it's a good thing to remove unwanted soft resets but wonder if
it did open a can of worms?
Atleast this fixes one iMX6 FEC/RMII/8081 combo.
Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
Signed-off-by: Christian Melki <christian.melki@t2data.com>
---
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 54e0d75203da..57f8021b70af 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1295,6 +1295,7 @@ static struct phy_driver ksphy_driver[] = {
.driver_data = &ksz8081_type,
.probe = kszphy_probe,
.config_init = ksz8081_config_init,
+ .soft_reset = genphy_soft_reset,
.config_intr = kszphy_config_intr,
.handle_interrupt = kszphy_handle_interrupt,
.get_sset_count = kszphy_get_sset_count,
next reply other threads:[~2021-02-18 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 21:09 Christian Melki [this message]
2021-02-23 3:04 ` [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb8b25e-f646-ed3d-8572-9b6ef318ae9e@t2data.com \
--to=christian.melki@t2data.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).