* [PATCH net-next] r8169: use r8168d_modify_extpage in rtl8168f_config_eee_phy
@ 2019-11-13 22:03 Heiner Kallweit
2019-11-15 2:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-11-13 22:03 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller; +Cc: netdev
Use r8168d_modify_extpage() also in rtl8168f_config_eee_phy() to
simplify the code.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 9a21ac962..8b33c1aa3 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -2324,11 +2324,7 @@ static void rtl8168f_config_eee_phy(struct rtl8169_private *tp)
{
struct phy_device *phydev = tp->phydev;
- phy_write(phydev, 0x1f, 0x0007);
- phy_write(phydev, 0x1e, 0x0020);
- phy_set_bits(phydev, 0x15, BIT(8));
- phy_write(phydev, 0x1f, 0x0000);
-
+ r8168d_modify_extpage(phydev, 0x0020, 0x15, 0, BIT(8));
r8168d_phy_param(phydev, 0x8b85, 0, BIT(13));
}
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] r8169: use r8168d_modify_extpage in rtl8168f_config_eee_phy
2019-11-13 22:03 [PATCH net-next] r8169: use r8168d_modify_extpage in rtl8168f_config_eee_phy Heiner Kallweit
@ 2019-11-15 2:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-15 2:00 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Wed, 13 Nov 2019 23:03:26 +0100
> Use r8168d_modify_extpage() also in rtl8168f_config_eee_phy() to
> simplify the code.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-15 2:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 22:03 [PATCH net-next] r8169: use r8168d_modify_extpage in rtl8168f_config_eee_phy Heiner Kallweit
2019-11-15 2:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).