netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: phy: realtek: support paged operations on RTL8201CP
@ 2020-11-08 21:44 Heiner Kallweit
  2020-11-11  0:13 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2020-11-08 21:44 UTC (permalink / raw)
  To: Jakub Kicinski, David Miller, Andrew Lunn, Russell King - ARM Linux
  Cc: netdev

The RTL8401-internal PHY identifies as RTL8201CP, and the init
sequence in r8169, copied from vendor driver r8168, uses paged
operations. Therefore set the same paged operation callbacks as
for the other Realtek PHY's.

Fixes: cdafdc29ef75 ("r8169: sync support for RTL8401 with vendor driver")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 2ba0d73bf..5844cf2d3 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -551,6 +551,8 @@ static struct phy_driver realtek_drvs[] = {
 	{
 		PHY_ID_MATCH_EXACT(0x00008201),
 		.name           = "RTL8201CP Ethernet",
+		.read_page	= rtl821x_read_page,
+		.write_page	= rtl821x_write_page,
 	}, {
 		PHY_ID_MATCH_EXACT(0x001cc816),
 		.name		= "RTL8201F Fast Ethernet",
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: phy: realtek: support paged operations on RTL8201CP
  2020-11-08 21:44 [PATCH net] net: phy: realtek: support paged operations on RTL8201CP Heiner Kallweit
@ 2020-11-11  0:13 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-11-11  0:13 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: David Miller, Andrew Lunn, Russell King - ARM Linux, netdev

On Sun, 8 Nov 2020 22:44:02 +0100 Heiner Kallweit wrote:
> The RTL8401-internal PHY identifies as RTL8201CP, and the init
> sequence in r8169, copied from vendor driver r8168, uses paged
> operations. Therefore set the same paged operation callbacks as
> for the other Realtek PHY's.
> 
> Fixes: cdafdc29ef75 ("r8169: sync support for RTL8401 with vendor driver")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-11  0:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-08 21:44 [PATCH net] net: phy: realtek: support paged operations on RTL8201CP Heiner Kallweit
2020-11-11  0:13 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).