From: Florian Fainelli <f.fainelli@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Matthias Brugger <matthias.bgg@kernel.org>,
Matthias Brugger <mbrugger@suse.com>,
"David S . Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Eric Anholt <eric@anholt.net>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Doug Berger <opendmb@gmail.com>,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC V2 6/6] ARM: dts: bcm2711-rpi-4: Enable GENET support
Date: Sat, 2 Nov 2019 13:02:38 -0700 [thread overview]
Message-ID: <69e7a48f-4a31-32af-9c04-889a44e19f96@gmail.com> (raw)
In-Reply-To: <1572702093-18261-7-git-send-email-wahrenst@gmx.net>
On 11/2/2019 6:41 AM, Stefan Wahren wrote:
> This enables the Gigabit Ethernet support on the Raspberry Pi 4.
> The defined PHY mode is equivalent to the default register settings
> in the downstream tree.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> ---
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 23 +++++++++++++++++++++++
> arch/arm/boot/dts/bcm2711.dtsi | 19 +++++++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> index cccc1cc..904efe1 100644
> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
> @@ -19,6 +19,10 @@
> reg = <0 0 0>;
> };
>
> + aliases {
> + ethernet0 = &genet;
> + };
> +
> leds {
> act {
> gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;
> @@ -97,6 +101,25 @@
> status = "okay";
> };
>
> +&genet {
> + phy-handle = <&phy1>;
> + phy-mode = "rgmii-rxid";
> + status = "okay";
> +
> + mdio@e14 {
> + compatible = "brcm,genet-mdio-v5";
> + reg = <0xe14 0x8>;
> + reg-names = "mdio";
> + #address-cells = <0x0>;
> + #size-cells = <0x1>;
The MDIO controller is always present, therefore its node definition
would be better placed in bcm2711.dtsi. Other than that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2019-11-02 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 13:41 [PATCH RFC V2 0/6] ARM: Enable GENET support for RPi 4 Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 1/6] net: bcmgenet: Fix error handling on IRQ retrieval Stefan Wahren
2019-11-02 19:43 ` Florian Fainelli
2019-11-02 13:41 ` [PATCH RFC V2 2/6] net: bcmgenet: Avoid touching non-existent interrupt Stefan Wahren
2019-11-02 19:34 ` Florian Fainelli
2019-11-03 9:36 ` Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 3/6] net: bcmgenet: use optional max DMA burst size property Stefan Wahren
2019-11-02 19:34 ` Florian Fainelli
2019-11-03 9:48 ` Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 4/6] net: bcmgenet: Refactor register access in bcmgenet_mii_config Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 5/6] net: bcmgenet: Add RGMII_RXID and RGMII_ID support Stefan Wahren
2019-11-02 20:00 ` Florian Fainelli
2019-11-03 9:34 ` Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 6/6] ARM: dts: bcm2711-rpi-4: Enable GENET support Stefan Wahren
2019-11-02 20:02 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69e7a48f-4a31-32af-9c04-889a44e19f96@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=opendmb@gmail.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).