netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Stefan Wahren <wahrenst@gmx.net>,
	Matthias Brugger <matthias.bgg@kernel.org>,
	Matthias Brugger <mbrugger@suse.com>,
	"David S . Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: Eric Anholt <eric@anholt.net>,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Doug Berger <opendmb@gmail.com>,
	netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC V2 5/6] net: bcmgenet: Add RGMII_RXID and RGMII_ID support
Date: Sat, 2 Nov 2019 13:00:05 -0700	[thread overview]
Message-ID: <b1b998af-c28f-f037-647d-63c4fb52fe95@gmail.com> (raw)
In-Reply-To: <1572702093-18261-6-git-send-email-wahrenst@gmx.net>



On 11/2/2019 6:41 AM, Stefan Wahren wrote:
> This adds the missing support for the PHY modes RGMII_RXID and
> RGMII_ID. This is necessary for the Raspberry Pi 4.

Are both used? Your next patch only uses "rgmii-rxid". Can you remind me
of the GTXC and RXC skew setting the PHY you are using comes up with?
And this was tested with Broadcom PHY (drivers/net/phy/broadcom.c)
driver or with the Generic PHY driver?
-- 
Florian

  reply	other threads:[~2019-11-02 20:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02 13:41 [PATCH RFC V2 0/6] ARM: Enable GENET support for RPi 4 Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 1/6] net: bcmgenet: Fix error handling on IRQ retrieval Stefan Wahren
2019-11-02 19:43   ` Florian Fainelli
2019-11-02 13:41 ` [PATCH RFC V2 2/6] net: bcmgenet: Avoid touching non-existent interrupt Stefan Wahren
2019-11-02 19:34   ` Florian Fainelli
2019-11-03  9:36     ` Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 3/6] net: bcmgenet: use optional max DMA burst size property Stefan Wahren
2019-11-02 19:34   ` Florian Fainelli
2019-11-03  9:48     ` Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 4/6] net: bcmgenet: Refactor register access in bcmgenet_mii_config Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 5/6] net: bcmgenet: Add RGMII_RXID and RGMII_ID support Stefan Wahren
2019-11-02 20:00   ` Florian Fainelli [this message]
2019-11-03  9:34     ` Stefan Wahren
2019-11-02 13:41 ` [PATCH RFC V2 6/6] ARM: dts: bcm2711-rpi-4: Enable GENET support Stefan Wahren
2019-11-02 20:02   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1b998af-c28f-f037-647d-63c4fb52fe95@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=eric@anholt.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=matthias.bgg@kernel.org \
    --cc=mbrugger@suse.com \
    --cc=netdev@vger.kernel.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=opendmb@gmail.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).