From: Heiner Kallweit <hkallweit1@gmail.com>
To: Chunhao Lin <hau@realtek.com>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH net] r8169: fix rtl8168h wol fail
Date: Thu, 5 Jan 2023 20:37:07 +0100 [thread overview]
Message-ID: <714782c5-b955-4511-23c0-9688224bba84@gmail.com> (raw)
In-Reply-To: <20230105180408.2998-1-hau@realtek.com>
On 05.01.2023 19:04, Chunhao Lin wrote:
> rtl8168h has an application that it will connect to rtl8211fs through mdi
> interface. And rtl8211fs will connect to fiber through serdes interface.
> In this application, rtl8168h revision id will be set to 0x2a.
>
> Because rtl8211fs's firmware will set link capability to 100M and GIGA
> when link is from off to on. So when system suspend and wol is enabled,
> rtl8168h will speed down to 100M (because rtl8211fs advertise 100M and GIGA
> to rtl8168h). If the link speed between rtl81211fs and fiber is GIGA.
> The link speed between rtl8168h and fiber will mismatch. That will cause
> wol fail.
>
> In this patch, if rtl8168h is in this kind of application, driver will not
> speed down phy when wol is enabled.
>
I think the patch title is inappropriate because WoL works normally on
RTL8168h in the standard setup.
What you add isn't a fix but a workaround for a firmware bug in RTL8211FS.
As mentioned in a previous review comment: if speed on fibre side is 1Gbps
then RTL8211FS shouldn't advertise 100Mbps on MDI/UTP side.
Last but not least the user can still use e.g. ethtool to change the speed
to 100Mbps thus breaking the link.
> Signed-off-by: Chunhao Lin <hau@realtek.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 24592d972523..83d017369ae7 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -1199,6 +1199,12 @@ static enum rtl_dash_type rtl_check_dash(struct rtl8169_private *tp)
> }
> }
>
> +static bool rtl_mdi_connect_to_phy(struct rtl8169_private *tp)
A comment would be helpful so that a reader of the code knows
what it's good for. A brief description of the non-standard
setup with the internal PHY connected to another PHY in media
converter mode would be good.
> +{
> + return tp->mac_version == RTL_GIGA_MAC_VER_46 &&
> + tp->pci_dev->revision == 0x2a;
> +}
> +
> static void rtl_set_d3_pll_down(struct rtl8169_private *tp, bool enable)
> {
> switch (tp->mac_version) {
> @@ -2453,7 +2459,8 @@ static void rtl_prepare_power_down(struct rtl8169_private *tp)
> rtl_ephy_write(tp, 0x19, 0xff64);
>
> if (device_may_wakeup(tp_to_dev(tp))) {
> - phy_speed_down(tp->phydev, false);
> + if (!rtl_mdi_connect_to_phy(tp))
> + phy_speed_down(tp->phydev, false);
> rtl_wol_enable_rx(tp);
> }
> }
next prev parent reply other threads:[~2023-01-05 19:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 18:04 [PATCH net] r8169: fix rtl8168h wol fail Chunhao Lin
2023-01-05 19:37 ` Heiner Kallweit [this message]
2023-01-05 21:26 ` Andrew Lunn
2023-01-06 6:53 ` Hau
2023-01-06 14:03 ` Andrew Lunn
2023-01-06 18:40 ` Heiner Kallweit
2023-01-10 17:03 ` Hau
2023-01-10 21:59 ` Heiner Kallweit
2023-01-11 17:23 ` Hau
2023-01-11 19:40 ` Heiner Kallweit
2023-01-11 21:40 ` Andrew Lunn
2023-01-13 16:23 ` Hau
2023-01-13 16:36 ` Andrew Lunn
2023-01-13 22:28 ` Heiner Kallweit
2023-01-16 17:04 ` Hau
2023-01-16 17:59 ` Heiner Kallweit
2023-01-18 16:57 ` Hau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=714782c5-b955-4511-23c0-9688224bba84@gmail.com \
--to=hkallweit1@gmail.com \
--cc=hau@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).