* [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets
@ 2018-05-31 22:37 Petr Machata
2018-05-31 22:37 ` [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap Petr Machata
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Petr Machata @ 2018-05-31 22:37 UTC (permalink / raw)
To: netdev, linux-kselftest; +Cc: davem, shuah, idosch
This patchset includes two small fixes for the tests that were
introduced in commit 1bb58d2d3cbe ("Merge branch
'Mirroring-tests-involving-VLAN'").
In patch #1, a "tc action trap" is uninstalled after the suite runs,
instead of being installed again.
In patch #2, a test in suite is renamed to differentiate it from another
test of the same name.
Petr Machata (2):
selftests: forwarding: mirror_vlan: Uninstall trap
selftests: forwarding: mirror_vlan: Change test description
tools/testing/selftests/net/forwarding/mirror_vlan.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.4.11
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap
2018-05-31 22:37 [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets Petr Machata
@ 2018-05-31 22:37 ` Petr Machata
2018-05-31 22:37 ` [PATCH net-next 2/2] selftests: forwarding: mirror_vlan: Change test description Petr Machata
2018-06-04 14:09 ` [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Petr Machata @ 2018-05-31 22:37 UTC (permalink / raw)
To: netdev, linux-kselftest; +Cc: davem, shuah, idosch
Instead of installing a trap before tests run and uninstalling it after
they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo.
Signed-off-by: Petr Machata <petrm@mellanox.com>
---
tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
index 1e10520..c22e949 100755
--- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh
+++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
@@ -146,7 +146,7 @@ test_all()
tests_run
- trap_install $h3 ingress
+ trap_uninstall $h3 ingress
slow_path_trap_uninstall $swp1 egress
slow_path_trap_uninstall $swp1 ingress
}
--
2.4.11
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next 2/2] selftests: forwarding: mirror_vlan: Change test description
2018-05-31 22:37 [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets Petr Machata
2018-05-31 22:37 ` [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap Petr Machata
@ 2018-05-31 22:37 ` Petr Machata
2018-06-04 14:09 ` [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Petr Machata @ 2018-05-31 22:37 UTC (permalink / raw)
To: netdev, linux-kselftest; +Cc: davem, shuah, idosch
The test description is displayed with the PASS/FAIL resolution after
the test is ran. There however already is one other test described
exactly like this, which makes it unclear which of the tests passed or
failed. Make the description unique.
Signed-off-by: Petr Machata <petrm@mellanox.com>
---
tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/mirror_vlan.sh b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
index c22e949..efade19 100755
--- a/tools/testing/selftests/net/forwarding/mirror_vlan.sh
+++ b/tools/testing/selftests/net/forwarding/mirror_vlan.sh
@@ -129,7 +129,7 @@ test_tagged_vlan_dir()
192.0.2.17 192.0.2.18
mirror_uninstall $swp1 $direction
- log_test "$direction mirror to vlan ($tcflags)"
+ log_test "$direction mirror tagged to vlan ($tcflags)"
}
test_tagged_vlan()
--
2.4.11
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets
2018-05-31 22:37 [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets Petr Machata
2018-05-31 22:37 ` [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap Petr Machata
2018-05-31 22:37 ` [PATCH net-next 2/2] selftests: forwarding: mirror_vlan: Change test description Petr Machata
@ 2018-06-04 14:09 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-06-04 14:09 UTC (permalink / raw)
To: petrm; +Cc: netdev, linux-kselftest, shuah, idosch
From: Petr Machata <petrm@mellanox.com>
Date: Fri, 01 Jun 2018 00:37:29 +0200
> This patchset includes two small fixes for the tests that were
> introduced in commit 1bb58d2d3cbe ("Merge branch
> 'Mirroring-tests-involving-VLAN'").
>
> In patch #1, a "tc action trap" is uninstalled after the suite runs,
> instead of being installed again.
>
> In patch #2, a test in suite is renamed to differentiate it from another
> test of the same name.
Series applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-04 14:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-31 22:37 [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets Petr Machata
2018-05-31 22:37 ` [PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap Petr Machata
2018-05-31 22:37 ` [PATCH net-next 2/2] selftests: forwarding: mirror_vlan: Change test description Petr Machata
2018-06-04 14:09 ` [PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).