* [PATCH] net/mlx5e: Make use of pr_warn()
@ 2021-08-09 9:08 Cai Huoqing
2021-08-09 10:24 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: Cai Huoqing @ 2021-08-09 9:08 UTC (permalink / raw)
To: saeedm, leon; +Cc: netdev, linux-rdma, Cai Huoqing
to replace printk(KERN_WARNING ...) with pr_warn() kindly
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index e5c4344a114e..ab7c059e630f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -2702,7 +2702,7 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
if (s_mask && a_mask) {
NL_SET_ERR_MSG_MOD(extack,
"can't set and add to the same HW field");
- printk(KERN_WARNING "mlx5: can't set and add to the same HW field (%x)\n", f->field);
+ pr_warn("mlx5: can't set and add to the same HW field (%x)\n", f->field);
return -EOPNOTSUPP;
}
@@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
if (first < next_z && next_z < last) {
NL_SET_ERR_MSG_MOD(extack,
"rewrite of few sub-fields isn't supported");
- printk(KERN_WARNING "mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
- mask);
+ pr_warn("mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
+ mask);
return -EOPNOTSUPP;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5e: Make use of pr_warn()
2021-08-09 9:08 [PATCH] net/mlx5e: Make use of pr_warn() Cai Huoqing
@ 2021-08-09 10:24 ` Leon Romanovsky
2021-08-09 20:37 ` Saeed Mahameed
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2021-08-09 10:24 UTC (permalink / raw)
To: Cai Huoqing; +Cc: saeedm, netdev, linux-rdma
On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:
> to replace printk(KERN_WARNING ...) with pr_warn() kindly
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index e5c4344a114e..ab7c059e630f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -2702,7 +2702,7 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
> if (s_mask && a_mask) {
> NL_SET_ERR_MSG_MOD(extack,
> "can't set and add to the same HW field");
> - printk(KERN_WARNING "mlx5: can't set and add to the same HW field (%x)\n", f->field);
> + pr_warn("mlx5: can't set and add to the same HW field (%x)\n", f->field);
It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.
> return -EOPNOTSUPP;
> }
>
> @@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct mlx5e_priv *priv,
> if (first < next_z && next_z < last) {
> NL_SET_ERR_MSG_MOD(extack,
> "rewrite of few sub-fields isn't supported");
> - printk(KERN_WARNING "mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
> - mask);
> + pr_warn("mlx5: rewrite of few sub-fields (mask %lx) isn't offloaded\n",
> + mask);
ditto
Thanks
> return -EOPNOTSUPP;
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5e: Make use of pr_warn()
2021-08-09 10:24 ` Leon Romanovsky
@ 2021-08-09 20:37 ` Saeed Mahameed
0 siblings, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2021-08-09 20:37 UTC (permalink / raw)
To: caihuoqing, leon; +Cc: netdev, linux-rdma
On Mon, 2021-08-09 at 13:24 +0300, Leon Romanovsky wrote:
> On Mon, Aug 09, 2021 at 05:08:43PM +0800, Cai Huoqing wrote:
>
[...]
> > - printk(KERN_WARNING "mlx5: can't set and
> > add to the same HW field (%x)\n", f->field);
> > + pr_warn("mlx5: can't set and add to the
> > same HW field (%x)\n", f->field);
>
> It should be "mlx5_core_warn(priv->mdev, ....") and not pr_warn.
>
please use: netdev_warn(priv->netdev,
> > return -EOPNOTSUPP;
> > }
> >
> > @@ -2741,8 +2741,8 @@ static int offload_pedit_fields(struct
> > mlx5e_priv *priv,
> > if (first < next_z && next_z < last) {
> > NL_SET_ERR_MSG_MOD(extack,
> > "rewrite of few sub-
> > fields isn't supported");
> > - printk(KERN_WARNING "mlx5: rewrite of few
> > sub-fields (mask %lx) isn't offloaded\n",
> > - mask);
> > + pr_warn("mlx5: rewrite of few sub-fields
> > (mask %lx) isn't offloaded\n",
> > + mask);
>
> ditto
>
same
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-09 20:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 9:08 [PATCH] net/mlx5e: Make use of pr_warn() Cai Huoqing
2021-08-09 10:24 ` Leon Romanovsky
2021-08-09 20:37 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).