netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
	Voon Weifeng <weifeng.voon@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	Russell King <linux@armlinux.org.uk>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Giuseppe Cavallaro" <peppe.cavallaro@st.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	biao huang <biao.huang@mediatek.com>,
	Ong Boon Leong <boon.leong.ong@intel.com>,
	"Kweh Hock Leong" <hock.leong.kweh@intel.com>
Subject: RE: [PATCH net-next v6 2/5] net: stmmac: introducing support for DWC xPCS logics
Date: Wed, 5 Jun 2019 13:13:22 +0000	[thread overview]
Message-ID: <78EB27739596EE489E55E81C33FEC33A0B93EF69@DE02WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: <05cf54dc-7c40-471e-f08a-7fdf5fe4ef54@gmail.com>

From: Florian Fainelli <f.fainelli@gmail.com>

> +Russell,
> 
> On 6/4/2019 11:58 AM, Voon Weifeng wrote:
> > From: Ong Boon Leong <boon.leong.ong@intel.com>
> > 
> > xPCS is DWC Ethernet Physical Coding Sublayer that may be integrated
> > into a GbE controller that uses DWC EQoS MAC controller. An example of
> > HW configuration is shown below:-
> > 
> >   <-----------------GBE Controller---------->|<--External PHY chip-->
> > 
> >   +----------+         +----+    +---+               +--------------+
> >   |   EQoS   | <-GMII->| DW |<-->|PHY| <-- SGMII --> | External GbE |
> >   |   MAC    |         |xPCS|    |IF |               | PHY Chip     |
> >   +----------+         +----+    +---+               +--------------+
> >          ^               ^                                  ^
> >          |               |                                  |
> >          +---------------------MDIO-------------------------+
> > 
> > xPCS is a Clause-45 MDIO Manageable Device (MMD) and we need a way to
> > differentiate it from external PHY chip that is discovered over MDIO.
> > Therefore, xpcs_phy_addr is introduced in stmmac platform data
> > (plat_stmmacenet_data) for differentiating xPCS from 'phy_addr' that
> > belongs to external PHY.
> 
> Assuming this DW xPCS can be found with designs other than STMMAC would
> not it make sense to model this as some kind of PHY/MDIO bridge? A
> little bit like what drivers/net/phy/xilinx_gmii2rgmii.c tries to do?

Yes, DW XPCS is a separate IP that can be sold without the MAC.

Thanks,
Jose Miguel Abreu

  reply	other threads:[~2019-06-05 13:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 18:58 [PATCH net-next v6 0/5] net: stmmac: enable EHL SGMII Voon Weifeng
2019-06-04 14:09 ` Jose Abreu
2019-06-04 18:58 ` [PATCH net-next v6 1/5] net: stmmac: enable clause 45 mdio support Voon Weifeng
2019-06-04 18:58 ` [PATCH net-next v6 2/5] net: stmmac: introducing support for DWC xPCS logics Voon Weifeng
2019-06-04 20:46   ` Florian Fainelli
2019-06-05 13:13     ` Jose Abreu [this message]
2019-06-07  0:23       ` Ong, Boon Leong
2019-06-20  5:13         ` Ong, Boon Leong
2019-06-04 18:58 ` [PATCH net-next v6 3/5] net: stmmac: add xpcs function hooks into main driver and ethtool Voon Weifeng
2019-06-04 18:58 ` [PATCH net-next v6 4/5] net: stmmac: add xPCS functions for device with DWMACv5.1 Voon Weifeng
2019-06-04 18:58 ` [PATCH net-next v6 5/5] net: stmmac: add EHL SGMII 1Gbps PCI info and PCI ID Voon Weifeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78EB27739596EE489E55E81C33FEC33A0B93EF69@DE02WEMBXB.internal.synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=alexandre.torgue@st.com \
    --cc=andrew@lunn.ch \
    --cc=biao.huang@mediatek.com \
    --cc=boon.leong.ong@intel.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=hock.leong.kweh@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=weifeng.voon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).