From: Randy Dunlap <rdunlap@infradead.org>
To: Peter Oskolkov <posk@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org
Cc: Peter Oskolkov <posk@posk.io>
Subject: Re: [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET
Date: Fri, 15 Feb 2019 14:55:58 -0800 [thread overview]
Message-ID: <7bbc8f63-3033-44ba-5b8e-ae597677bbe6@infradead.org> (raw)
In-Reply-To: <20190215175135.35549-1-posk@google.com>
On 2/15/19 9:51 AM, Peter Oskolkov wrote:
> Lightweight tunnels are L3 constructs that are used with IP/IP6.
>
> For example, lwtunnel_xmit is called from ip_output.c and
> ip6_output.c only.
>
> Make the dependency explicit at least for LWT-BPF, as now they
> call into IP routing.
>
> V2: added "Reported-by" below.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Peter Oskolkov <posk@google.com>
Yes, that works. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> ---
> net/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 5cb9de1aaf88..62da6148e9f8 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -403,7 +403,7 @@ config LWTUNNEL
>
> config LWTUNNEL_BPF
> bool "Execute BPF program as route nexthop action"
> - depends on LWTUNNEL
> + depends on LWTUNNEL && INET
> default y if LWTUNNEL=y
> ---help---
> Allows to run BPF programs as a nexthop action following a route
>
--
~Randy
next prev parent reply other threads:[~2019-02-15 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 17:51 [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET Peter Oskolkov
2019-02-15 22:55 ` Randy Dunlap [this message]
2019-02-16 0:16 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bbc8f63-3033-44ba-5b8e-ae597677bbe6@infradead.org \
--to=rdunlap@infradead.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
--cc=posk@posk.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).