From: Michael Walle <michael@walle.cc>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: mdio: mscc-miim: replace magic numbers for the bus reset
Date: Sun, 13 Mar 2022 02:17:55 +0100 [thread overview]
Message-ID: <7cbe529d46c64b01eb99c016d9f16f1a@walle.cc> (raw)
In-Reply-To: <Yi1ALN6hN9aV1VrA@lunn.ch>
Am 2022-03-13 01:51, schrieb Andrew Lunn:
>> diff --git a/drivers/net/mdio/mdio-mscc-miim.c
>> b/drivers/net/mdio/mdio-mscc-miim.c
>> index 64fb76c1e395..7773d5019e66 100644
>> --- a/drivers/net/mdio/mdio-mscc-miim.c
>> +++ b/drivers/net/mdio/mdio-mscc-miim.c
>> @@ -158,18 +158,18 @@ static int mscc_miim_reset(struct mii_bus *bus)
>> {
>> struct mscc_miim_dev *miim = bus->priv;
>> int offset = miim->phy_reset_offset;
>> + int mask = PHY_CFG_PHY_ENA | PHY_CFG_PHY_COMMON_RESET |
>> + PHY_CFG_PHY_RESET;
>
>> - ret = regmap_write(miim->phy_regs,
>> - MSCC_PHY_REG_PHY_CFG + offset, 0x1ff);
>> + ret = regmap_write(miim->phy_regs, offset, mask);
>
> Is mask the correct name? It is not being used in the typical way for
> a mask.
It is the mask of all the reset bits, see also patch 3/3. Either all
these bits are set or none. Do you have any suggestion? I thought about
adding mask and value for the remap_update_bits() in patch 3/3 but
decided against it, just because it doesn't add any value because
mask and value are the same.
-michael
next prev parent reply other threads:[~2022-03-13 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 0:21 [PATCH net-next 0/3] net: mscc-miim: add integrated PHY reset support Michael Walle
2022-03-13 0:21 ` [PATCH net-next 1/3] dt-bindings: net: mscc-miim: add lan966x compatible Michael Walle
2022-03-13 0:21 ` [PATCH net-next 2/3] net: mdio: mscc-miim: replace magic numbers for the bus reset Michael Walle
2022-03-13 0:51 ` Andrew Lunn
2022-03-13 1:17 ` Michael Walle [this message]
2022-03-13 14:52 ` Andrew Lunn
2022-03-13 0:21 ` [PATCH net-next 3/3] et: mdio: mscc-miim: add lan966x internal phy reset support Michael Walle
2022-03-13 14:44 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cbe529d46c64b01eb99c016d9f16f1a@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).