From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] et: mdio: mscc-miim: add lan966x internal phy reset support
Date: Sun, 13 Mar 2022 15:44:00 +0100 [thread overview]
Message-ID: <Yi4DMGnpiOswNiXp@lunn.ch> (raw)
In-Reply-To: <20220313002153.11280-4-michael@walle.cc>
> /* When high resolution timers aren't built-in: we can't use usleep_range() as
> @@ -157,27 +166,29 @@ static int mscc_miim_write(struct mii_bus *bus, int mii_id,
> static int mscc_miim_reset(struct mii_bus *bus)
> {
> struct mscc_miim_dev *miim = bus->priv;
> - int offset = miim->phy_reset_offset;
> - int mask = PHY_CFG_PHY_ENA | PHY_CFG_PHY_COMMON_RESET |
> - PHY_CFG_PHY_RESET;
> + unsigned int offset, mask;
> int ret;
>
> - if (miim->phy_regs) {
> - ret = regmap_write(miim->phy_regs, offset, 0);
> - if (ret < 0) {
> - WARN_ONCE(1, "mscc reset set error %d\n", ret);
> - return ret;
> - }
> + if (!miim->phy_regs || !miim->info)
> + return 0;
I would put the check for miim->info in the probe. Not checking the
return value from *_get_match_data() is one of the things the bots
reports and we receive patches for. You have the check, but it is
hidden away, and i doubt the bot nor the bot handlers are clever
enough to find it.
Andrew
prev parent reply other threads:[~2022-03-13 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 0:21 [PATCH net-next 0/3] net: mscc-miim: add integrated PHY reset support Michael Walle
2022-03-13 0:21 ` [PATCH net-next 1/3] dt-bindings: net: mscc-miim: add lan966x compatible Michael Walle
2022-03-13 0:21 ` [PATCH net-next 2/3] net: mdio: mscc-miim: replace magic numbers for the bus reset Michael Walle
2022-03-13 0:51 ` Andrew Lunn
2022-03-13 1:17 ` Michael Walle
2022-03-13 14:52 ` Andrew Lunn
2022-03-13 0:21 ` [PATCH net-next 3/3] et: mdio: mscc-miim: add lan966x internal phy reset support Michael Walle
2022-03-13 14:44 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi4DMGnpiOswNiXp@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).