[PATCH 0/8] reduce indentation

[PATCH 0/8] reduce indentation

[Julia Lawall]

These patches fix cases where a subsequent statement is aligned
with the right hand side of an assignment rather than the left
hand side.  This was done using the following semantic match
(http://coccinelle.lip6.fr/).  It has a lot of false positives,
because Coccinelle doesn't record the difference between a space
and a tab, but these issues are easy to skip over.

// <smpl>
@r@
expression x,e;
statement S;
position p0,p1,p2;
@@
x@p0 = e@p1;
S@p2

@script:ocaml@
p0 << r.p0;
p1 << r.p1;
p2 << r.p2;
@@
if ((List.hd p0).col < (List.hd p1).col &&
    (List.hd p1).col = (List.hd p2).col)
then Coccilib.print_main "" p1
// </smpl>

---

 drivers/firmware/stratix10-svc.c              |   12 ++++++------
 drivers/gpu/drm/msm/dsi/phy/dsi_phy.c         |    2 +-
 drivers/iommu/msm_iommu.c                     |    8 ++++----
 drivers/net/ethernet/amazon/ena/ena_eth_com.c |    4 ++--
 drivers/net/ethernet/intel/i40e/i40e_main.c   |    2 +-
 drivers/scsi/pm8001/pm8001_sas.c              |    2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |    6 +++---
 drivers/usb/gadget/udc/snps_udc_core.c        |   17 ++++++++---------
 8 files changed, 26 insertions(+), 27 deletions(-)

[PATCH 2/8] net: ena: reduce indentation

[Julia Lawall]

Delete tab aligning a statement with the right hand side of a
preceding assignment rather than the left hand side.

Found with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/net/ethernet/amazon/ena/ena_eth_com.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_eth_com.c b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
index f6c2d3855be8..f7b4e359a2ff 100644
--- a/drivers/net/ethernet/amazon/ena/ena_eth_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
@@ -200,8 +200,8 @@ static inline int ena_com_sq_update_llq_tail(struct ena_com_io_sq *io_sq)
 
 		pkt_ctrl->curr_bounce_buf =
 			ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);
-			memset(io_sq->llq_buf_ctrl.curr_bounce_buf,
-			       0x0, llq_info->desc_list_entry_size);
+		memset(io_sq->llq_buf_ctrl.curr_bounce_buf,
+		       0x0, llq_info->desc_list_entry_size);
 
 		pkt_ctrl->idx = 0;
 		if (unlikely(llq_info->desc_stride_ctrl == ENA_ADMIN_SINGLE_DESC_PER_ENTRY))

[PATCH 3/8] i40e: increase indentation

[Julia Lawall]

Convert spaces to tabs to get correct alignment.

Found with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 4d40878e395a..6c435b61941f 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -3610,7 +3610,7 @@ static void i40e_configure_msi_and_legacy(struct i40e_vsi *vsi)
 		      (I40E_QUEUE_TYPE_TX
 		       << I40E_QINT_TQCTL_NEXTQ_TYPE_SHIFT);
 
-	       wr32(hw, I40E_QINT_TQCTL(nextqp), val);
+		wr32(hw, I40E_QINT_TQCTL(nextqp), val);
 	}
 
 	val = I40E_QINT_TQCTL_CAUSE_ENA_MASK		      |

Re: [PATCH 3/8] i40e: increase indentation

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote:
> Convert spaces to tabs to get correct alignment.
> 
> Found with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Dave, since this is apart of a series, please feel free to commit this
patch with the series.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 3/8] i40e: increase indentation

[David Miller]

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 03 Jan 2019 15:58:10 -0800

> On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote:
>> Convert spaces to tabs to get correct alignment.
>> 
>> Found with the help of Coccinelle.
>> 
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>> 
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> 
> Dave, since this is apart of a series, please feel free to commit this
> patch with the series.

It's kind of net-next material and therefore would need to be re-submitted
anyways when net-next opens up.

Alternatively, Jeff, you can toss it into your -next tree.

Re: [PATCH 3/8] i40e: increase indentation

[Jeff Kirsher]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Thu, 2019-01-03 at 16:37 -0800, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Thu, 03 Jan 2019 15:58:10 -0800
> 
> > On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote:
> > > Convert spaces to tabs to get correct alignment.
> > > 
> > > Found with the help of Coccinelle.
> > > 
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> > > 
> > > ---
> > >  drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > 
> > Dave, since this is apart of a series, please feel free to commit
> > this
> > patch with the series.
> 
> It's kind of net-next material and therefore would need to be re-
> submitted
> anyways when net-next opens up.
> 
> Alternatively, Jeff, you can toss it into your -next tree.

Ok will do.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

RE: [Intel-wired-lan] [PATCH 3/8] i40e: increase indentation

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> Behalf Of Julia Lawall
> Sent: Sunday, December 30, 2018 7:53 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; kernel-janitors@vger.kernel.org; David
> S. Miller <davem@davemloft.net>; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH 3/8] i40e: increase indentation
> 
> Convert spaces to tabs to get correct alignment.
> 
> Found with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

RE: [Intel-wired-lan] [PATCH 3/8] i40e: increase indentation

[Bowers, AndrewX]

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
> Behalf Of Julia Lawall
> Sent: Sunday, December 30, 2018 7:53 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; kernel-janitors@vger.kernel.org; David
> S. Miller <davem@davemloft.net>; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH 3/8] i40e: increase indentation
> 
> Convert spaces to tabs to get correct alignment.
> 
> Found with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>