netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: Fix errors in af_llc.c
       [not found] <tencent_4CED92D1C8320CEA29489ED8DFEF3614EB05@qq.com>
@ 2023-07-18  5:48 ` shijie001
  2023-07-18 19:47   ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: shijie001 @ 2023-07-18  5:48 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel

The following checkpatch errors are removed:
ERROR: "foo* bar" should be "foo *bar"
ERROR: space required before the open parenthesis '('

Signed-off-by: Jie Shi <shijie001@208suo.com>
---
  net/llc/af_llc.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
index 9ffbc667be6c..f0891088e7be 100644
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c
@@ -124,9 +124,9 @@ static inline u8 llc_ui_header_len(struct sock *sk, 
struct sockaddr_llc *addr)
   *
   *    This function always consumes a reference to the skb.
   */
-static int llc_ui_send_data(struct sock* sk, struct sk_buff *skb, int 
noblock)
+static int llc_ui_send_data(struct sock *sk, struct sk_buff *skb, int 
noblock)
  {
-    struct llc_sock* llc = llc_sk(sk);
+    struct llc_sock *llc = llc_sk(sk);

      if (unlikely(llc_data_accept_state(llc->state) ||
               llc->remote_busy_flag ||
@@ -1030,7 +1030,7 @@ static int llc_ui_getname(struct socket *sock, 
struct sockaddr *uaddr,
          rc = -ENOTCONN;
          if (sk->sk_state != TCP_ESTABLISHED)
              goto out;
-        if(llc->dev)
+        if (llc->dev)
              sllc.sllc_arphrd = llc->dev->type;
          sllc.sllc_sap = llc->daddr.lsap;
          memcpy(&sllc.sllc_mac, &llc->daddr.mac, IFHWADDRLEN);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: Fix errors in af_llc.c
  2023-07-18  5:48 ` [PATCH] net: Fix errors in af_llc.c shijie001
@ 2023-07-18 19:47   ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-07-18 19:47 UTC (permalink / raw)
  To: shijie001; +Cc: davem, edumazet, pabeni, netdev, linux-kernel

On Tue, 18 Jul 2023 13:48:33 +0800 shijie001@208suo.com wrote:
> The following checkpatch errors are removed:
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: space required before the open parenthesis '('
> 
> Signed-off-by: Jie Shi <shijie001@208suo.com>

Please don't send checkpatch fixes to networking.
Your patches are whitespace damaged.

We had an influx of similar changes recently.
Are you part of some organized effort?
-- 
pw-bot: reject

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-18 19:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tencent_4CED92D1C8320CEA29489ED8DFEF3614EB05@qq.com>
2023-07-18  5:48 ` [PATCH] net: Fix errors in af_llc.c shijie001
2023-07-18 19:47   ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).