* [PATCH net-next] net: phy: Do not check Link status when loopback is enabled
@ 2019-09-05 11:43 Jose Abreu
2019-09-06 13:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jose Abreu @ 2019-09-05 11:43 UTC (permalink / raw)
To: netdev
Cc: Joao Pinto, Jose Abreu, Andrew Lunn, Florian Fainelli,
Heiner Kallweit, David S. Miller, linux-kernel
While running stmmac selftests I found that in my 1G setup some tests
were failling when running with PHY loopback enabled.
It looks like when loopback is enabled the PHY will report that Link is
down even though there is a valid connection.
As in loopback mode the data will not be sent anywhere we can bypass the
logic of checking if Link is valid thus saving unecessary reads.
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
---
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/net/phy/phy.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 35d29a823af8..7c92afd36bbe 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -525,6 +525,12 @@ static int phy_check_link_status(struct phy_device *phydev)
WARN_ON(!mutex_is_locked(&phydev->lock));
+ /* Keep previous state if loopback is enabled because some PHYs
+ * report that Link is Down when loopback is enabled.
+ */
+ if (phydev->loopback_enabled)
+ return 0;
+
err = phy_read_status(phydev);
if (err)
return err;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: phy: Do not check Link status when loopback is enabled
2019-09-05 11:43 [PATCH net-next] net: phy: Do not check Link status when loopback is enabled Jose Abreu
@ 2019-09-06 13:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-09-06 13:11 UTC (permalink / raw)
To: Jose.Abreu
Cc: netdev, Joao.Pinto, andrew, f.fainelli, hkallweit1, linux-kernel
From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Thu, 5 Sep 2019 13:43:10 +0200
> While running stmmac selftests I found that in my 1G setup some tests
> were failling when running with PHY loopback enabled.
>
> It looks like when loopback is enabled the PHY will report that Link is
> down even though there is a valid connection.
>
> As in loopback mode the data will not be sent anywhere we can bypass the
> logic of checking if Link is valid thus saving unecessary reads.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-06 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 11:43 [PATCH net-next] net: phy: Do not check Link status when loopback is enabled Jose Abreu
2019-09-06 13:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).