* [PATCH net-next] r8169: remove MAC workaround in rtl8168e_2_hw_phy_config
@ 2019-12-21 13:11 Heiner Kallweit
2019-12-25 6:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-12-21 13:11 UTC (permalink / raw)
To: Realtek linux nic maintainers, David Miller; +Cc: netdev
Due to recent changes we don't need the call to rtl_rar_exgmac_set()
and longer at this place. It's called from rtl_rar_set() which is
called in rtl_init_mac_address() and rtl8169_resume().
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index c845a5850..38a09b5ee 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -2961,9 +2961,6 @@ static void rtl8168e_2_hw_phy_config(struct rtl8169_private *tp)
rtl_writephy(tp, 0x1f, 0x0005);
rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000);
rtl_writephy(tp, 0x1f, 0x0000);
-
- /* Broken BIOS workaround: feed GigaMAC registers with MAC address. */
- rtl_rar_exgmac_set(tp, tp->dev->dev_addr);
}
static void rtl8168f_hw_phy_config(struct rtl8169_private *tp)
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] r8169: remove MAC workaround in rtl8168e_2_hw_phy_config
2019-12-21 13:11 [PATCH net-next] r8169: remove MAC workaround in rtl8168e_2_hw_phy_config Heiner Kallweit
@ 2019-12-25 6:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-12-25 6:27 UTC (permalink / raw)
To: hkallweit1; +Cc: nic_swsd, netdev
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sat, 21 Dec 2019 14:11:08 +0100
> Due to recent changes we don't need the call to rtl_rar_exgmac_set()
> and longer at this place. It's called from rtl_rar_set() which is
> called in rtl_init_mac_address() and rtl8169_resume().
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-25 6:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-21 13:11 [PATCH net-next] r8169: remove MAC workaround in rtl8168e_2_hw_phy_config Heiner Kallweit
2019-12-25 6:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).