* [PATCH net] ionic: update the queue count on open
@ 2020-06-25 20:12 Shannon Nelson
2020-06-25 22:57 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Shannon Nelson @ 2020-06-25 20:12 UTC (permalink / raw)
To: netdev, davem; +Cc: Shannon Nelson
Let the network stack know the real number of queues that
we are using.
Fixes: 49d3b493673a ("ionic: disable the queues on link down")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index aaa00edd9d5b..62858c7afae0 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -1673,6 +1673,9 @@ int ionic_open(struct net_device *netdev)
if (err)
goto err_out;
+ netif_set_real_num_tx_queues(netdev, lif->nxqs);
+ netif_set_real_num_rx_queues(netdev, lif->nxqs);
+
/* don't start the queues until we have link */
if (netif_carrier_ok(netdev)) {
err = ionic_start_queues(lif);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ionic: update the queue count on open
2020-06-25 20:12 [PATCH net] ionic: update the queue count on open Shannon Nelson
@ 2020-06-25 22:57 ` Jakub Kicinski
2020-06-25 23:08 ` Shannon Nelson
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2020-06-25 22:57 UTC (permalink / raw)
To: Shannon Nelson; +Cc: netdev, davem
On Thu, 25 Jun 2020 13:12:15 -0700 Shannon Nelson wrote:
> Let the network stack know the real number of queues that
> we are using.
>
> Fixes: 49d3b493673a ("ionic: disable the queues on link down")
> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index aaa00edd9d5b..62858c7afae0 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -1673,6 +1673,9 @@ int ionic_open(struct net_device *netdev)
> if (err)
> goto err_out;
>
> + netif_set_real_num_tx_queues(netdev, lif->nxqs);
> + netif_set_real_num_rx_queues(netdev, lif->nxqs);
These calls can fail.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ionic: update the queue count on open
2020-06-25 22:57 ` Jakub Kicinski
@ 2020-06-25 23:08 ` Shannon Nelson
0 siblings, 0 replies; 3+ messages in thread
From: Shannon Nelson @ 2020-06-25 23:08 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, davem
On 6/25/20 3:57 PM, Jakub Kicinski wrote:
> On Thu, 25 Jun 2020 13:12:15 -0700 Shannon Nelson wrote:
>> Let the network stack know the real number of queues that
>> we are using.
>>
>> Fixes: 49d3b493673a ("ionic: disable the queues on link down")
>> Signed-off-by: Shannon Nelson <snelson@pensando.io>
>> ---
>> drivers/net/ethernet/pensando/ionic/ionic_lif.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> index aaa00edd9d5b..62858c7afae0 100644
>> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
>> @@ -1673,6 +1673,9 @@ int ionic_open(struct net_device *netdev)
>> if (err)
>> goto err_out;
>>
>> + netif_set_real_num_tx_queues(netdev, lif->nxqs);
>> + netif_set_real_num_rx_queues(netdev, lif->nxqs);
> These calls can fail.
Ah, yes they can. I'll update this.
sln
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-25 23:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 20:12 [PATCH net] ionic: update the queue count on open Shannon Nelson
2020-06-25 22:57 ` Jakub Kicinski
2020-06-25 23:08 ` Shannon Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).