From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>,
Greg KH <greg@kroah.com>
Cc: "xiyou.wangcong\@gmail.com" <xiyou.wangcong@gmail.com>,
"davem\@davemloft.net" <davem@davemloft.net>,
"jhs\@mojatatu.com" <jhs@mojatatu.com>,
"jiri\@resnulli.us" <jiri@resnulli.us>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest\@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"shuah\@kernel.org" <shuah@kernel.org>
Subject: Re: [net-next v2] net: sched: Introduce act_ctinfo action
Date: Sun, 05 May 2019 12:43:20 +0200 [thread overview]
Message-ID: <8736lt9o6v.fsf@toke.dk> (raw)
In-Reply-To: <B6426224-12CC-417B-9A38-6DDBE574A85C@darbyshire-bryant.me.uk>
Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk> writes:
>> On 5 May 2019, at 11:23, Greg KH <greg@kroah.com> wrote:
>>
>> On Sun, May 05, 2019 at 10:15:43AM +0000, Kevin 'ldir' Darbyshire-Bryant wrote:
>>> --- /dev/null
>>> +++ b/net/sched/act_ctinfo.c
>>> @@ -0,0 +1,407 @@
>>> +// SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
>>
>
> Hey Greg, thanks for the review.
>
>> How can a .c file, buried in the kernel tree, have a Linux-syscall-note
>> exception to it?
>
> Because I’m a moron and nobody else spotted it.
>>
>> Are you _sure_ that is ok? That license should only be for files in the
>> uapi header directory.
>
> Expect a v3 shortly. I shall wear your chastisement with honour :-)
While you're at it, you don't actually need the GPL text blob when using
the SPDX headers... :)
-Toke
next prev parent reply other threads:[~2019-05-05 10:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 13:08 [PATCH net-next] net: sched: Introduce act_ctinfo action Kevin 'ldir' Darbyshire-Bryant
2019-04-30 21:47 ` Cong Wang
2019-05-03 21:20 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:15 ` [net-next v2] " Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:23 ` Greg KH
2019-05-05 10:32 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:43 ` Toke Høiland-Jørgensen [this message]
2019-05-05 13:20 ` [net-next v3] " Kevin 'ldir' Darbyshire-Bryant
2019-05-07 19:39 ` David Miller
2019-05-07 20:12 ` [PATCH net-next v4] " Kevin 'ldir' Darbyshire-Bryant
2019-05-08 0:20 ` David Miller
2019-05-08 16:12 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-07 20:18 ` [net-next v3] " Kevin 'ldir' Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736lt9o6v.fsf@toke.dk \
--to=toke@redhat.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=ldir@darbyshire-bryant.me.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).