From: Kevin 'ldir' Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next] net: sched: Introduce act_ctinfo action
Date: Fri, 3 May 2019 21:20:03 +0000 [thread overview]
Message-ID: <9FB6B9CF-1767-4598-8859-C5D8A47DEC85@darbyshire-bryant.me.uk> (raw)
In-Reply-To: <CAM_iQpXnXyfLZ2+gjDufbdMrZLgtf9uKbzbUf50Xm-2Go7maVw@mail.gmail.com>
> On 30 Apr 2019, at 22:47, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>
> On Sat, Apr 27, 2019 at 6:08 AM Kevin 'ldir' Darbyshire-Bryant
> <ldir@darbyshire-bryant.me.uk> wrote:
>>
>> ctinfo is a new tc filter action module. It is designed to restore DSCPs
>> stored in conntrack marks into the ipv4/v6 diffserv field.
>
> I think we can retrieve any information from conntrack with such
> a general name, including skb mark. So, as you already pick the
> name ctinfo, please make it general rather than just DSCP.
> You can add skb mark into your ctinfo too so that act_connmark
> can be just replaced.
Hi Cong,
Thanks for the review, I have a v2 in progress addressing that along
with another silly that got through. I’m also re-working the stats
reporting to return act_ctinfo stats instead of usurping the dropped,
overlimits & dropped figures.
>
> Your patch looks fine from a quick galance, please make sure
> you run checkpatch.pl to keep your coding style aligned to Linux
> kernel's, at least I don't think we accept C++ style comments.
This time I’ll remember to run checkpatch before I submit instead of
after :-)
>
> Thanks.
Cheers,
Kevin D-B
gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A
next prev parent reply other threads:[~2019-05-03 21:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 13:08 [PATCH net-next] net: sched: Introduce act_ctinfo action Kevin 'ldir' Darbyshire-Bryant
2019-04-30 21:47 ` Cong Wang
2019-05-03 21:20 ` Kevin 'ldir' Darbyshire-Bryant [this message]
2019-05-05 10:15 ` [net-next v2] " Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:23 ` Greg KH
2019-05-05 10:32 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-05 10:43 ` Toke Høiland-Jørgensen
2019-05-05 13:20 ` [net-next v3] " Kevin 'ldir' Darbyshire-Bryant
2019-05-07 19:39 ` David Miller
2019-05-07 20:12 ` [PATCH net-next v4] " Kevin 'ldir' Darbyshire-Bryant
2019-05-08 0:20 ` David Miller
2019-05-08 16:12 ` Kevin 'ldir' Darbyshire-Bryant
2019-05-07 20:18 ` [net-next v3] " Kevin 'ldir' Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9FB6B9CF-1767-4598-8859-C5D8A47DEC85@darbyshire-bryant.me.uk \
--to=ldir@darbyshire-bryant.me.uk \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).