From: Baruch Siach <baruch@tkos.co.il>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
"Jonathan Corbet" <corbet@lwn.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
"Ulisses Alonso Camaró" <uaca@alumni.uv.es>
Subject: Re: [PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP
Date: Sun, 20 Dec 2020 09:52:55 +0200 [thread overview]
Message-ID: <875z4wq5go.fsf@tarshish> (raw)
In-Reply-To: <20201217102037.6f5ceee9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hi Jakub,
On Thu, Dec 17 2020, Jakub Kicinski wrote:
> On Tue, 15 Dec 2020 18:51:17 +0200 Baruch Siach wrote:
>> Before commit 889b8f964f2f ("packet: Kill CONFIG_PACKET_MMAP.") there
>> used to be a CONFIG_PACKET_MMAP config symbol that depended on
>> CONFIG_PACKET. The text still refers to PACKET_MMAP as the name of this
>> feature, implying that it can be disabled. Another naming variant is
>> "Packet MMAP".
>>
>> Use "PACKET mmap()" everywhere to unify the terminology. Rephrase the
>> text the implied mmap() feature disable option.
>
> Should we maybe say AF_PACKET mmap() ?
I thought that PACKET is better because it is the minimal change, and
because of the reference to CONFIG_PACKET. Should we rename
CONFIG_PACKET to CONFIG_AF_PACKET as well?
What do you think?
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2020-12-20 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 16:51 [PATCH net 1/2] docs: networking: packet_mmap: fix formatting for C macros Baruch Siach
2020-12-15 16:51 ` [PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP Baruch Siach
2020-12-17 18:20 ` Jakub Kicinski
2020-12-17 21:28 ` Willem de Bruijn
2020-12-20 7:58 ` Baruch Siach
2020-12-20 14:52 ` Willem de Bruijn
2020-12-20 7:52 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z4wq5go.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=uaca@alumni.uv.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).