From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Baruch Siach" <baruch@tkos.co.il>,
"David S. Miller" <davem@davemloft.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Network Development" <netdev@vger.kernel.org>,
linux-doc@vger.kernel.org,
"Ulisses Alonso Camaró" <uaca@alumni.uv.es>
Subject: Re: [PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP
Date: Thu, 17 Dec 2020 16:28:54 -0500 [thread overview]
Message-ID: <CA+FuTScTEthUW=s+5_jnnHj4SQeFr0=HsgwVeNegNOaCNQ+C=Q@mail.gmail.com> (raw)
In-Reply-To: <20201217102037.6f5ceee9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Dec 17, 2020 at 2:48 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 15 Dec 2020 18:51:17 +0200 Baruch Siach wrote:
> > Before commit 889b8f964f2f ("packet: Kill CONFIG_PACKET_MMAP.") there
> > used to be a CONFIG_PACKET_MMAP config symbol that depended on
> > CONFIG_PACKET. The text still refers to PACKET_MMAP as the name of this
> > feature, implying that it can be disabled. Another naming variant is
> > "Packet MMAP".
> >
> > Use "PACKET mmap()" everywhere to unify the terminology. Rephrase the
> > text the implied mmap() feature disable option.
>
> Should we maybe say AF_PACKET mmap() ?
I don't think that the feature name PACKET_MMAP implies
CONFIG_PACKET_MMAP, or thus that the name is obsolete now that the
latter is.
If it needs a rename, the setsockopt is PACKET_[RT]X_RING. So, if this
needs updating, perhaps PACKET_RING would be suitable. Or TPACKET,
based on the version definitions.
next prev parent reply other threads:[~2020-12-17 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 16:51 [PATCH net 1/2] docs: networking: packet_mmap: fix formatting for C macros Baruch Siach
2020-12-15 16:51 ` [PATCH net 2/2] docs: networking: packet_mmap: don't mention PACKET_MMAP Baruch Siach
2020-12-17 18:20 ` Jakub Kicinski
2020-12-17 21:28 ` Willem de Bruijn [this message]
2020-12-20 7:58 ` Baruch Siach
2020-12-20 14:52 ` Willem de Bruijn
2020-12-20 7:52 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTScTEthUW=s+5_jnnHj4SQeFr0=HsgwVeNegNOaCNQ+C=Q@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=baruch@tkos.co.il \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=uaca@alumni.uv.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).