From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Jens Axboe <axboe@kernel.dk>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
Networking <netdev@vger.kernel.org>
Subject: Re: iwlwifi warnings in 5.5-rc1
Date: Wed, 11 Dec 2019 11:23:02 +0100 [thread overview]
Message-ID: <875zingnzt.fsf@toke.dk> (raw)
In-Reply-To: <3420d73e667b01ec64bf0cc9da6232b41e862860.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2019-12-11 at 09:53 +0100, Toke Høiland-Jørgensen wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>> > On Tue, 2019-12-10 at 13:46 -0700, Jens Axboe wrote:
>> > > Hi,
>> > >
>> > > Since the GRO issue got fixed, iwlwifi has worked fine for me.
>> > > However, on every boot, I get some warnings:
>> > >
>> > > ------------[ cut here ]------------
>> > > STA b4:75:0e:99:1f:e0 AC 2 txq pending airtime underflow: 4294967088, 208
>> >
>> > Yeah, we've seen a few reports of this.
>>
>> FWIW I've tried reproducing but I don't get the error with the 8265 /
>> 8275 chip in my laptop. I've thought about sending a patch for mac80211
>> to just clear the tx_time_est field after calling
>> ieee80211_sta_update_pending_airtime() - that should prevent any errors
>> from double-reporting of skbs (which is what I'm guessing is going on
>> here).
>
> It does feel like it, but I'm not sure how that'd be possible?
>
> OK, I talked with Emmanuel and I think it's the GSO path - it'll end up
> with skb_clone() and then report both of them back.
Right, figured it was something like that; just couldn't find the place
in the driver where it did that from my cursory browsing.
> Regardless, I think I'll probably have to disable AQL and make it more
> opt-in for the driver - I found a bunch of other issues ...
Issues like what? Making it opt-in was going to be my backup plan; I was
kinda hoping we could work out any issues so it would be a "no harm"
kind of thing that could be left as always-on. Maybe that was a bit too
optimistic; but it's also a pain having to keep track of which drivers
have which features/fixes...
-Toke
next prev parent reply other threads:[~2019-12-11 10:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 20:46 iwlwifi warnings in 5.5-rc1 Jens Axboe
2019-12-11 8:36 ` Johannes Berg
2019-12-11 8:53 ` Toke Høiland-Jørgensen
2019-12-11 10:11 ` Johannes Berg
2019-12-11 10:23 ` Toke Høiland-Jørgensen [this message]
2019-12-11 11:51 ` Johannes Berg
2019-12-11 13:42 ` Johannes Berg
2019-12-11 14:04 ` Toke Høiland-Jørgensen
2019-12-11 14:12 ` Johannes Berg
2019-12-11 14:47 ` Toke Høiland-Jørgensen
2019-12-11 21:18 ` Johannes Berg
2019-12-12 10:45 ` Toke Høiland-Jørgensen
2019-12-11 14:02 ` Toke Høiland-Jørgensen
2019-12-11 21:17 ` Johannes Berg
2019-12-12 10:55 ` Toke Høiland-Jørgensen
2019-12-12 11:00 ` Johannes Berg
2019-12-21 0:55 ` Jens Axboe
2019-12-21 9:17 ` Johannes Berg
2019-12-21 13:45 ` Jens Axboe
2019-12-11 13:45 ` Johannes Berg
2019-12-11 14:09 ` Toke Høiland-Jørgensen
2019-12-11 14:13 ` Johannes Berg
2019-12-11 14:55 ` Toke Høiland-Jørgensen
2019-12-11 21:19 ` Johannes Berg
2019-12-12 10:55 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zingnzt.fsf@toke.dk \
--to=toke@redhat.com \
--cc=axboe@kernel.dk \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).